[GitHub] [superset] genzgd commented on pull request #22039: feat: use a new official CH driver: clickhouse-connect

[GitBox <gi...@apache.org>]

genzgd commented on PR #22039:
URL: https://github.com/apache/superset/pull/22039#issuecomment-1310874781

   I think tests are little tricky because `clickhouse-connect` provides its own EngineSpec class that is not part of the superset package or code base.  As far as I know this is the only EngineSpec that works this way, and it uses the Python "entry point" mechanism to do that.
   
   The result is the class to test is `clickhouse_connect.cc_superset.engine.ClickHouseEngineSpec` instead of `superset.db_engine_specs.clickhouse` -- `superset.db_engine_specs.clickhouse` is coupled with the clickhouse-sqlachemy library.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org