You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/03/13 08:13:50 UTC
Review Request 19174: Fixed a race condition in Latch which could lead to
incorrect return value for Latch::await().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19174/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-1088
https://issues.apache.org/jira/browse/MESOS-1088
Repository: mesos-git
Description
-------
See https://issues.apache.org/jira/browse/MESOS-1088
The symptom was that the 'Future::await(Duration)' returns 'false' even though the future is set before it times out.
Diffs
-----
3rdparty/libprocess/src/latch.cpp a6f1256ff8860e9a624c0f200ea53912048fd6e3
Diff: https://reviews.apache.org/r/19174/diff/
Testing
-------
Ran ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster 1000 iterations.
make check 10 iterations.
Thanks,
Jiang Yan Xu
Re: Review Request 19174: Fixed a race condition in Latch which could lead
to incorrect return value for Latch::await().
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19174/
-----------------------------------------------------------
(Updated March 14, 2014, 3:25 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
assigning to @benjaminhindman to shepherd. -- vinod
Bugs: MESOS-1088
https://issues.apache.org/jira/browse/MESOS-1088
Repository: mesos-git
Description
-------
See https://issues.apache.org/jira/browse/MESOS-1088
The symptom was that the 'Future::await(Duration)' returns 'false' even though the future is set before it times out.
Diffs
-----
3rdparty/libprocess/src/latch.cpp a6f1256ff8860e9a624c0f200ea53912048fd6e3
Diff: https://reviews.apache.org/r/19174/diff/
Testing
-------
Ran ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster 1000 iterations.
make check 10 iterations.
Thanks,
Jiang Yan Xu
Re: Review Request 19174: Fixed a race condition in Latch which could lead
to incorrect return value for Latch::await().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19174/#review37132
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 13, 2014, 7:13 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19174/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 7:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1088
> https://issues.apache.org/jira/browse/MESOS-1088
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/MESOS-1088
>
> The symptom was that the 'Future::await(Duration)' returns 'false' even though the future is set before it times out.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/latch.cpp a6f1256ff8860e9a624c0f200ea53912048fd6e3
>
> Diff: https://reviews.apache.org/r/19174/diff/
>
>
> Testing
> -------
>
> Ran ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster 1000 iterations.
> make check 10 iterations.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>