You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/03/16 14:06:29 UTC
[jira] Created: (NET-375) DotTerminatedMessageReader should extend
BufferedReader, rather than Reader
DotTerminatedMessageReader should extend BufferedReader, rather than Reader
---------------------------------------------------------------------------
Key: NET-375
URL: https://issues.apache.org/jira/browse/NET-375
Project: Commons Net
Issue Type: Improvement
Affects Versions: 2.2
Reporter: Sebb
DotTerminatedMessageReader is a line oriented reader, yet does not extend BufferedReader.
This means that frequently it needs to be wrapped in a BufferedReader.
Also, it currently has to mess about with adding line endings so that the enclosing BufferedReader will work OK.
This potentially changes the original input stream more than necessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-375) DotTerminatedMessageReader should extend
BufferedReader, rather than Reader
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated NET-375:
---------------------
Fix Version/s: 3.0
> DotTerminatedMessageReader should extend BufferedReader, rather than Reader
> ---------------------------------------------------------------------------
>
> Key: NET-375
> URL: https://issues.apache.org/jira/browse/NET-375
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Sebb
> Fix For: 3.0
>
>
> DotTerminatedMessageReader is a line oriented reader, yet does not extend BufferedReader.
> This means that frequently it needs to be wrapped in a BufferedReader.
> Also, it currently has to mess about with adding line endings so that the enclosing BufferedReader will work OK.
> This potentially changes the original input stream more than necessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (NET-375) DotTerminatedMessageReader should extend
BufferedReader, rather than Reader
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-375.
----------------------
Resolution: Fixed
Extending Buffered reader allowed the PushBack reader to be eliminated, and the code simplified.
The class now supports readLine() directly.
> DotTerminatedMessageReader should extend BufferedReader, rather than Reader
> ---------------------------------------------------------------------------
>
> Key: NET-375
> URL: https://issues.apache.org/jira/browse/NET-375
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Sebb
>
> DotTerminatedMessageReader is a line oriented reader, yet does not extend BufferedReader.
> This means that frequently it needs to be wrapped in a BufferedReader.
> Also, it currently has to mess about with adding line endings so that the enclosing BufferedReader will work OK.
> This potentially changes the original input stream more than necessary.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira