You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Nettleton <rn...@hortonworks.com> on 2015/05/18 20:31:02 UTC

Re: Review Request 34365: Remove un-used "hive_dbroot" configuration property from HDP stack definitions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34365/
-----------------------------------------------------------

(Updated May 18, 2015, 6:31 p.m.)


Review request for Ambari, John Speidel, Mahadev Konar, Robert Levas, and Yusaku Sako.


Summary (updated)
-----------------

Remove un-used "hive_dbroot" configuration property from HDP stack definitions


Bugs: AMBARI-11222
    https://issues.apache.org/jira/browse/AMBARI-11222


Repository: ambari


Description
-------

This patch addresses AMBARI-11222. 

The "hive_rootdb" property in the HDP stack definitions was added in a previous release, but was never used by Ambari. 

This patch removes this property from the HDP stack defintions.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
  ambari-server/src/main/resources/custom_actions/scripts/validate_configs.py 4529539 
  ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/global.xml d9adc80 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0d924e9 

Diff: https://reviews.apache.org/r/34365/diff/


Testing
-------

1. Ran ambari-server unit tests, all passing. 
2. Deployed a single-node Hive cluster using the Ambari UI.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected. 
3. Deployed a single-node Hive cluster using a Blueprint.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected.


Thanks,

Robert Nettleton


Re: Review Request 34365: Remove un-used "hive_dbroot" configuration property from HDP stack definitions

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34365/#review84188
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On May 18, 2015, 2:31 p.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34365/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 2:31 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Mahadev Konar, Robert Levas, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-11222
>     https://issues.apache.org/jira/browse/AMBARI-11222
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch addresses AMBARI-11222. 
> 
> The "hive_dbroot" property in the HDP stack definitions was added in a previous release, but was never used by Ambari. 
> 
> This patch removes this property from the HDP stack defintions.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
>   ambari-server/src/main/resources/custom_actions/scripts/validate_configs.py 4529539 
>   ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/global.xml d9adc80 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0d924e9 
> 
> Diff: https://reviews.apache.org/r/34365/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran ambari-server unit tests, all passing. 
> 2. Deployed a single-node Hive cluster using the Ambari UI.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected. 
> 3. Deployed a single-node Hive cluster using a Blueprint.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Re: Review Request 34365: Remove un-used "hive_dbroot" configuration property from HDP stack definitions

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34365/#review84215
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On May 18, 2015, 6:31 p.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34365/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 6:31 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Mahadev Konar, Robert Levas, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-11222
>     https://issues.apache.org/jira/browse/AMBARI-11222
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch addresses AMBARI-11222. 
> 
> The "hive_dbroot" property in the HDP stack definitions was added in a previous release, but was never used by Ambari. 
> 
> This patch removes this property from the HDP stack defintions.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
>   ambari-server/src/main/resources/custom_actions/scripts/validate_configs.py 4529539 
>   ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/global.xml d9adc80 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0d924e9 
> 
> Diff: https://reviews.apache.org/r/34365/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran ambari-server unit tests, all passing. 
> 2. Deployed a single-node Hive cluster using the Ambari UI.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected. 
> 3. Deployed a single-node Hive cluster using a Blueprint.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Re: Review Request 34365: Remove un-used "hive_dbroot" configuration property from HDP stack definitions

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34365/
-----------------------------------------------------------

(Updated May 18, 2015, 6:31 p.m.)


Review request for Ambari, John Speidel, Mahadev Konar, Robert Levas, and Yusaku Sako.


Bugs: AMBARI-11222
    https://issues.apache.org/jira/browse/AMBARI-11222


Repository: ambari


Description (updated)
-------

This patch addresses AMBARI-11222. 

The "hive_dbroot" property in the HDP stack definitions was added in a previous release, but was never used by Ambari. 

This patch removes this property from the HDP stack defintions.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
  ambari-server/src/main/resources/custom_actions/scripts/validate_configs.py 4529539 
  ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/global.xml d9adc80 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 0d924e9 

Diff: https://reviews.apache.org/r/34365/diff/


Testing
-------

1. Ran ambari-server unit tests, all passing. 
2. Deployed a single-node Hive cluster using the Ambari UI.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected. 
3. Deployed a single-node Hive cluster using a Blueprint.  The cluster started up successfully.  There was an error in that WebHCat did not start properly, but this issue occurs without my patch applied, and is un-related. Other than WebHCat, all Hive services were up and running as expected.


Thanks,

Robert Nettleton