You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/18 09:27:23 UTC

[GitHub] raphinesse commented on a change in pull request #67: Test Framework Implementation Improvements

raphinesse commented on a change in pull request #67: Test Framework Implementation Improvements
URL: https://github.com/apache/cordova-osx/pull/67#discussion_r218358616
 
 

 ##########
 File path: package.json
 ##########
 @@ -15,10 +15,10 @@
     "cordova:platform"
   ],
   "scripts": {
-    "test": "npm run eslint && npm run jasmine",
-    "jasmine": "npm run objc-tests && npm run jasmine-tests",
-    "objc-tests": "jasmine tests/spec/cordovalib.spec.js",
-    "jasmine-tests": "jasmine tests/spec/create.spec.js tests/spec/platform.spec.js",
+    "test": "npm run eslint && npm run test:coverage",
+    "test:objc": "jasmine  --config=tests/spec/objc.json",
+    "test:component": "jasmine --config=tests/spec/component.json",
+    "test:coverage": "nyc jasmine --config=tests/spec/coverage.json",
 
 Review comment:
   naming the file `all.json` would have been more obvious to me. But that's only nitpicking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org