[GitHub] [libcloud] Kami commented on issue #1315: [WIP] Various Gridscale driver and paramiko SSH client improvements

[GitBox <gi...@apache.org>]

Kami commented on issue #1315: [WIP] Various Gridscale driver and paramiko SSH client improvements
URL: https://github.com/apache/libcloud/pull/1315#issuecomment-512322513
 
 
   I tried to test and get deployment to work, but it turned out it a huge time sink.
   
   Main problem is that paramiko only supports key files in old PKCS#1 PEM format. New style OpenSSH keys or key files in PEM format without `---BEGIN <type> PRIVATE KEY` header are not supported.
   
   I updated the code to handle such scenario better:
   
   1. Propagate "invalid key file" exception to the user instead of re-trying the deployment.
   2. If user passes in a key file which contains private key in a PEM format, but without a valid header we try to manually convert into into a format which paramiko accepts.
   
   We also need to add a note to our deployment documentation which clearly says what kind of keys paramiko supports so users won't waste as much time as I did on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services