You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/05/04 13:30:10 UTC

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 4, 2015, 5 p.m.)


Review request for lens.


Summary (updated)
-----------------

LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

posting for early comments.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java fbdefab3910c03e06cba082fc0677296de4f7415 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 8f088c0fde5063687482244648e526e145ec4d1a 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 86c3453473d7f0f8ac597aa82f007e721bcdd675 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 237164fd92a4bd1355cef6d90319328cafa3b9d4 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 24f7f1a5b05b53d268286253b41ac271c4adfa85 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 961faad9b2bd9d212654707f6591822a8f3ac561 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java eafd661aef84fefb06e8e4a500758bd7826f0567 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java e3a90d51703f31cdfcd0fc4cb089bb43dd3423e2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 70296aa71585ea8a8f8a74db3ecaa05981228719 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java c73b7ffae47834eb6e0d84f56df7de8400641745 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 5d9e97ecea541e0d82a22ab8365f79f2983d6695 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 097f2283b7defb2fe5703cf04f3dc276f18e341b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java f19221b0548196b3a88dd0451ed24035696e6e35 
  lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Amareshwari Sriramadasu <am...@apache.org>.


> On May 6, 2015, 12:13 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 331
> > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line331>
> >
> >     What is this pattern check done here? Are we allowing only < and <=?
> 
> Rajat Khandelwal wrote:
>     I could not find any suitable way of taking the argument. So just randomly picked the format `diff1 <= partcol < diff2`.
> 
> Rajat Khandelwal wrote:
>     It makes sense logically too. If we've said `order time +1hour <= delivery time < order time + 20 days`. Now, let's take a query with `ot` range `[a,b)`. Which means `a <= ot`. Which means `dt>=ot+1hour >= a+1hour`. Also, `ot > b` which implies `dt > ot+20days > b+20days`. So essencially we got `a+1hour <= dt < b+20days`, i.e. range `[a+1hour, b+20days)`. 
>     
>     
>     The only concern I have is regarding keeping `<` characters in xml. I did not get any errors in the syntax analyzer.

Another option i could think of is something like dt = ot+[1hr,20days). 

Only thing i'm thinking is - will we ever have usecases where you would have single value associated?  For ex : dt = ot + 3 days.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------


On May 7, 2015, 6:21 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 6:21 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 24d0d6440a7c9156a62aabd8dae6b50ecd5ab253 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java, line 90
> > <https://reviews.apache.org/r/33581/diff/6/?file=950872#file950872line90>
> >
> >     Whats the purpose of this formatter ?

For writing date in HQL. Hive expects a certain format of date fields.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java, line 65
> > <https://reviews.apache.org/r/33581/diff/6/?file=950874#file950874line65>
> >
> >     Why is the order changed? Doesnt it cause test failures?

post selection where clause is now null always. Earlier it was used to add not latest condition. Not latest condition is removed from here as well as test cases. Hence no test failure.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 364
> > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line364>
> >
> >     fallBackRange returned could be null. Do we need to handle null here?

No. If null, it'll just append `null`. Won't throw NPE. http://stackoverflow.com/questions/4260723/concatenating-null-strings-in-java


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-examples/src/main/resources/sales-cube.xml, line 151
> > <https://reviews.apache.org/r/33581/diff/6/?file=950894#file950894line151>
> >
> >     What does it mean in terms for order time and delivery time? Is ti saying delivery time is any time between order_time + 1hr to 20 days?

Precisely.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------


On May 6, 2015, 2:39 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 2:39 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 25173ebacf0733114593cee2fe0d3c28c6ea2885 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 331
> > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line331>
> >
> >     What is this pattern check done here? Are we allowing only < and <=?
> 
> Rajat Khandelwal wrote:
>     I could not find any suitable way of taking the argument. So just randomly picked the format `diff1 <= partcol < diff2`.
> 
> Rajat Khandelwal wrote:
>     It makes sense logically too. If we've said `order time +1hour <= delivery time < order time + 20 days`. Now, let's take a query with `ot` range `[a,b)`. Which means `a <= ot`. Which means `dt>=ot+1hour >= a+1hour`. Also, `ot > b` which implies `dt > ot+20days > b+20days`. So essencially we got `a+1hour <= dt < b+20days`, i.e. range `[a+1hour, b+20days)`. 
>     
>     
>     The only concern I have is regarding keeping `<` characters in xml. I did not get any errors in the syntax analyzer.
> 
> Amareshwari Sriramadasu wrote:
>     Another option i could think of is something like dt = ot+[1hr,20days). 
>     
>     Only thing i'm thinking is - will we ever have usecases where you would have single value associated?  For ex : dt = ot + 3 days.

single value can always be implemented by keeping both values same.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------


On May 7, 2015, 11:51 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 11:51 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 24d0d6440a7c9156a62aabd8dae6b50ecd5ab253 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 331
> > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line331>
> >
> >     What is this pattern check done here? Are we allowing only < and <=?

I could not find any suitable way of taking the argument. So just randomly picked the format `diff1 <= partcol < diff2`.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------


On May 6, 2015, 2:39 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 2:39 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 25173ebacf0733114593cee2fe0d3c28c6ea2885 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 331
> > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line331>
> >
> >     What is this pattern check done here? Are we allowing only < and <=?
> 
> Rajat Khandelwal wrote:
>     I could not find any suitable way of taking the argument. So just randomly picked the format `diff1 <= partcol < diff2`.

It makes sense logically too. If we've said `order time +1hour <= delivery time < order time + 20 days`. Now, let's take a query with `ot` range `[a,b)`. Which means `a <= ot`. Which means `dt>=ot+1hour >= a+1hour`. Also, `ot > b` which implies `dt > ot+20days > b+20days`. So essencially we got `a+1hour <= dt < b+20days`, i.e. range `[a+1hour, b+20days)`. 


The only concern I have is regarding keeping `<` characters in xml. I did not get any errors in the syntax analyzer.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------


On May 6, 2015, 8:01 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 8:01 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 24d0d6440a7c9156a62aabd8dae6b50ecd5ab253 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 331
> > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line331>
> >
> >     What is this pattern check done here? Are we allowing only < and <=?
> 
> Rajat Khandelwal wrote:
>     I could not find any suitable way of taking the argument. So just randomly picked the format `diff1 <= partcol < diff2`.
> 
> Rajat Khandelwal wrote:
>     It makes sense logically too. If we've said `order time +1hour <= delivery time < order time + 20 days`. Now, let's take a query with `ot` range `[a,b)`. Which means `a <= ot`. Which means `dt>=ot+1hour >= a+1hour`. Also, `ot > b` which implies `dt > ot+20days > b+20days`. So essencially we got `a+1hour <= dt < b+20days`, i.e. range `[a+1hour, b+20days)`. 
>     
>     
>     The only concern I have is regarding keeping `<` characters in xml. I did not get any errors in the syntax analyzer.
> 
> Amareshwari Sriramadasu wrote:
>     Another option i could think of is something like dt = ot+[1hr,20days). 
>     
>     Only thing i'm thinking is - will we ever have usecases where you would have single value associated?  For ex : dt = ot + 3 days.
> 
> Rajat Khandelwal wrote:
>     single value can always be implemented by keeping both values same.

And I'll go with the approach `ot+[1hr,20days)`. Here the values inside can be negative also e.g. `ot+[-10hr,20days)`. Taking this decision since `<` in xml is not a good idea.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------


On May 7, 2015, 11:51 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 11:51 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 24d0d6440a7c9156a62aabd8dae6b50ecd5ab253 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82663
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java
<https://reviews.apache.org/r/33581/#comment133459>

    Please add documentation of the property in cube xsd, and give details about the reg ex pattern accepted.



lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java
<https://reviews.apache.org/r/33581/#comment133450>

    Could not understand whats happening in this method. Can you add some comments?



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
<https://reviews.apache.org/r/33581/#comment133451>

    returning partition columns queried? Can we name accordingly?



lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java
<https://reviews.apache.org/r/33581/#comment133452>

    Whats the purpose of this formatter ?



lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java
<https://reviews.apache.org/r/33581/#comment133453>

    Why is the order changed? Doesnt it cause test failures?



lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
<https://reviews.apache.org/r/33581/#comment133454>

    Can you add some comments around code changes here?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/33581/#comment133456>

    What is this pattern check done here? Are we allowing only < and <=?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/33581/#comment133455>

    fallBackRange returned could be null. Do we need to handle null here?



lens-examples/src/main/resources/sales-cube.xml
<https://reviews.apache.org/r/33581/#comment133458>

    What does it mean in terms for order time and delivery time? Is ti saying delivery time is any time between order_time + 1hr to 20 days?


- Amareshwari Sriramadasu


On May 6, 2015, 9:09 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 9:09 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 25173ebacf0733114593cee2fe0d3c28c6ea2885 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
> [INFO] Lens .............................................. SUCCESS [2.729s]
> [INFO] Lens API .......................................... SUCCESS [19.890s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
> [INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
> [INFO] Lens DB storage ................................... SUCCESS [19.125s]
> [INFO] Lens Query Library ................................ SUCCESS [20.968s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
> [INFO] Lens Server ....................................... SUCCESS [5:54.523s]
> [INFO] Lens client ....................................... SUCCESS [45.558s]
> [INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
> [INFO] Lens Examples ..................................... SUCCESS [16.021s]
> [INFO] Lens Distribution ................................. SUCCESS [17.832s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
> [INFO] Lens Regression ................................... SUCCESS [8.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:57.456s
> [INFO] Finished at: Wed May 06 09:07:01 UTC 2015
> [INFO] Final Memory: 115M/1373M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 7, 2015, 3:31 p.m., Amareshwari Sriramadasu wrote:
> > lens-examples/src/main/resources/sales-cube.xml, line 157
> > <https://reviews.apache.org/r/33581/diff/8-9/?file=952222#file952222line157>
> >
> >     Shouldnt this be dt = ot + [1hour,20days) ?

Modified accordingly. No fallback partition now. Only timedim relation.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82813
-----------------------------------------------------------


On May 8, 2015, 4:19 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 4:19 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
>   lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
>   lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
>   lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
>   lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
>   lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
> [INFO] Lens .............................................. SUCCESS [3.371s]
> [INFO] Lens API .......................................... SUCCESS [26.972s]
> [INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
> [INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
> [INFO] Lens DB storage ................................... SUCCESS [33.380s]
> [INFO] Lens Query Library ................................ SUCCESS [29.792s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
> [INFO] Lens Server ....................................... SUCCESS [4:52.979s]
> [INFO] Lens client ....................................... SUCCESS [41.132s]
> [INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
> [INFO] Lens Examples ..................................... SUCCESS [9.252s]
> [INFO] Lens Distribution ................................. SUCCESS [11.228s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
> [INFO] Lens Regression ................................... SUCCESS [7.449s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:18.026s
> [INFO] Finished at: Thu May 07 08:59:21 UTC 2015
> [INFO] Final Memory: 113M/1253M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review82813
-----------------------------------------------------------



lens-examples/src/main/resources/sales-cube.xml
<https://reviews.apache.org/r/33581/#comment133639>

    Shouldnt this be dt = ot + [1hour,20days) ?



lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/33581/#comment133640>

    Needs changes with new format change.



lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/33581/#comment133642>

    Should the definition be always on partition column or optionally time dimension will also work?
    
    In examples : 
    Time dimension : order_time,
    part column : ot
    
    Should the definition be always on ot? 
    
    Should we accept definition for time dimension, for the cases where there is no explicit mapping to part column ? 
    
    I'm thinking actually we should take the definiion to be on time dimension instead of part column sothat all time dimensions (with a corresponding part column exists or not) can specify a fallback partition.



lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/33581/#comment133641>

    Can you give more details here ? Is space between number and unit supported? Are 4 days, 4days, 4day, 4 day same ?



lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/33581/#comment133643>

    Can you mention if the value is not specified, the value in cube definition will be used.


- Amareshwari Sriramadasu


On May 7, 2015, 9:59 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 9:59 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
>   lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
>   lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
>   lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
>   lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
>   lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
> [INFO] Lens .............................................. SUCCESS [3.371s]
> [INFO] Lens API .......................................... SUCCESS [26.972s]
> [INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
> [INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
> [INFO] Lens DB storage ................................... SUCCESS [33.380s]
> [INFO] Lens Query Library ................................ SUCCESS [29.792s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
> [INFO] Lens Server ....................................... SUCCESS [4:52.979s]
> [INFO] Lens client ....................................... SUCCESS [41.132s]
> [INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
> [INFO] Lens Examples ..................................... SUCCESS [9.252s]
> [INFO] Lens Distribution ................................. SUCCESS [11.228s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
> [INFO] Lens Regression ................................... SUCCESS [7.449s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:18.026s
> [INFO] Finished at: Thu May 07 08:59:21 UTC 2015
> [INFO] Final Memory: 113M/1253M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On May 11, 2015, 11:39 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, lines 67-95
> > <https://reviews.apache.org/r/33581/diff/12/?file=952953#file952953line67>
> >
> >     Can we make sure we have 100% unit test coverage for all the things documented here?

Have mentioned newly added test cases in testing done section. Please have a look. Should be sufficient. I have provided tests for all functionality that is said to be supported here.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review83202
-----------------------------------------------------------


On May 8, 2015, 4:51 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 4:51 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
>   lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
>   lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
>   lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
>   lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
>   lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
> [INFO] Lens .............................................. SUCCESS [3.371s]
> [INFO] Lens API .......................................... SUCCESS [26.972s]
> [INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
> [INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
> [INFO] Lens DB storage ................................... SUCCESS [33.380s]
> [INFO] Lens Query Library ................................ SUCCESS [29.792s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
> [INFO] Lens Server ....................................... SUCCESS [4:52.979s]
> [INFO] Lens client ....................................... SUCCESS [41.132s]
> [INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
> [INFO] Lens Examples ..................................... SUCCESS [9.252s]
> [INFO] Lens Distribution ................................. SUCCESS [11.228s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
> [INFO] Lens Regression ................................... SUCCESS [7.449s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:18.026s
> [INFO] Finished at: Thu May 07 08:59:21 UTC 2015
> [INFO] Final Memory: 113M/1253M
> [INFO] ------------------------------------------------------------------------
> 
> Newly added Example query also verified by running separately.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review83202
-----------------------------------------------------------



lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/33581/#comment134105>

    Can we make sure we have 100% unit test coverage for all the things documented here?


- Amareshwari Sriramadasu


On May 8, 2015, 11:21 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 11:21 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
>   lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
>   lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
>   lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
>   lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
>   lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
>   lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
> [INFO] Lens .............................................. SUCCESS [3.371s]
> [INFO] Lens API .......................................... SUCCESS [26.972s]
> [INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
> [INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
> [INFO] Lens DB storage ................................... SUCCESS [33.380s]
> [INFO] Lens Query Library ................................ SUCCESS [29.792s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
> [INFO] Lens Server ....................................... SUCCESS [4:52.979s]
> [INFO] Lens client ....................................... SUCCESS [41.132s]
> [INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
> [INFO] Lens Examples ..................................... SUCCESS [9.252s]
> [INFO] Lens Distribution ................................. SUCCESS [11.228s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
> [INFO] Lens Regression ................................... SUCCESS [7.449s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:18.026s
> [INFO] Finished at: Thu May 07 08:59:21 UTC 2015
> [INFO] Final Memory: 113M/1253M
> [INFO] ------------------------------------------------------------------------
> 
> Newly added Example query also verified by running separately.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS-198: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/#review83590
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On May 13, 2015, 11:02 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33581/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 11:02 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-198
>     https://issues.apache.org/jira/browse/LENS-198
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Allow timed dimensions to be a field and not a time partitioning column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 10b1dfa 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c0 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcba 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26fe 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 6646718 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf34 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc6114 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a32 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 3df704d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be3 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd51971 
>   lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15 
>   lens-examples/src/main/resources/cube-queries.sql 7a0b542 
>   lens-examples/src/main/resources/customer.xml 64024f1 
>   lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a8801 
>   lens-examples/src/main/resources/sales-aggr-fact2.xml b535a87 
>   lens-examples/src/main/resources/sales-cube.xml f5e2f93 
> 
> Diff: https://reviews.apache.org/r/33581/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
> [INFO] Lens .............................................. SUCCESS [3.371s]
> [INFO] Lens API .......................................... SUCCESS [26.972s]
> [INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
> [INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
> [INFO] Lens DB storage ................................... SUCCESS [33.380s]
> [INFO] Lens Query Library ................................ SUCCESS [29.792s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
> [INFO] Lens Server ....................................... SUCCESS [4:52.979s]
> [INFO] Lens client ....................................... SUCCESS [41.132s]
> [INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
> [INFO] Lens Examples ..................................... SUCCESS [9.252s]
> [INFO] Lens Distribution ................................. SUCCESS [11.228s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
> [INFO] Lens Regression ................................... SUCCESS [7.449s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:18.026s
> [INFO] Finished at: Thu May 07 08:59:21 UTC 2015
> [INFO] Final Memory: 113M/1253M
> [INFO] ------------------------------------------------------------------------
> 
> Newly added Example query also verified by running separately.
> 
> Newly added test cases:
> 1. Prefer fact that has part col for time dim queried
> 2. Missing partitions on fallback part col should be reported
> 3. transitive fallback
> 4. multiple time dims queried, then fallback should be local to the range where clause
> 5. prefer property in fact. tested in examples
> 6. fallback to property in cube. tested in test cases
> 7. Added test cases for time diff parsing
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 33581: LENS-198: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 13, 2015, 4:32 p.m.)


Review request for lens.


Summary (updated)
-----------------

LENS-198: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c0 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcba 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26fe 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 6646718 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23ded 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf34 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc6114 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa551 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3203354 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a32 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c915353 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 3df704d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b6 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be3 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd51971 
  lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15 
  lens-examples/src/main/resources/cube-queries.sql 7a0b542 
  lens-examples/src/main/resources/customer.xml 64024f1 
  lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a8801 
  lens-examples/src/main/resources/sales-aggr-fact2.xml b535a87 
  lens-examples/src/main/resources/sales-cube.xml f5e2f93 

Diff: https://reviews.apache.org/r/33581/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
[INFO] Lens .............................................. SUCCESS [3.371s]
[INFO] Lens API .......................................... SUCCESS [26.972s]
[INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
[INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
[INFO] Lens DB storage ................................... SUCCESS [33.380s]
[INFO] Lens Query Library ................................ SUCCESS [29.792s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
[INFO] Lens Server ....................................... SUCCESS [4:52.979s]
[INFO] Lens client ....................................... SUCCESS [41.132s]
[INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
[INFO] Lens Examples ..................................... SUCCESS [9.252s]
[INFO] Lens Distribution ................................. SUCCESS [11.228s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
[INFO] Lens Regression ................................... SUCCESS [7.449s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18.026s
[INFO] Finished at: Thu May 07 08:59:21 UTC 2015
[INFO] Final Memory: 113M/1253M
[INFO] ------------------------------------------------------------------------

Newly added Example query also verified by running separately.

Newly added test cases:
1. Prefer fact that has part col for time dim queried
2. Missing partitions on fallback part col should be reported
3. transitive fallback
4. multiple time dims queried, then fallback should be local to the range where clause
5. prefer property in fact. tested in examples
6. fallback to property in cube. tested in test cases
7. Added test cases for time diff parsing


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 8, 2015, 4:51 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
  lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
  lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
  lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
  lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
  lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 

Diff: https://reviews.apache.org/r/33581/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
[INFO] Lens .............................................. SUCCESS [3.371s]
[INFO] Lens API .......................................... SUCCESS [26.972s]
[INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
[INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
[INFO] Lens DB storage ................................... SUCCESS [33.380s]
[INFO] Lens Query Library ................................ SUCCESS [29.792s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
[INFO] Lens Server ....................................... SUCCESS [4:52.979s]
[INFO] Lens client ....................................... SUCCESS [41.132s]
[INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
[INFO] Lens Examples ..................................... SUCCESS [9.252s]
[INFO] Lens Distribution ................................. SUCCESS [11.228s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
[INFO] Lens Regression ................................... SUCCESS [7.449s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18.026s
[INFO] Finished at: Thu May 07 08:59:21 UTC 2015
[INFO] Final Memory: 113M/1253M
[INFO] ------------------------------------------------------------------------

Newly added Example query also verified by running separately.


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 8, 2015, 4:23 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
  lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
  lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
  lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
  lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
  lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
[INFO] Lens .............................................. SUCCESS [3.371s]
[INFO] Lens API .......................................... SUCCESS [26.972s]
[INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
[INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
[INFO] Lens DB storage ................................... SUCCESS [33.380s]
[INFO] Lens Query Library ................................ SUCCESS [29.792s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
[INFO] Lens Server ....................................... SUCCESS [4:52.979s]
[INFO] Lens client ....................................... SUCCESS [41.132s]
[INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
[INFO] Lens Examples ..................................... SUCCESS [9.252s]
[INFO] Lens Distribution ................................. SUCCESS [11.228s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
[INFO] Lens Regression ................................... SUCCESS [7.449s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18.026s
[INFO] Finished at: Thu May 07 08:59:21 UTC 2015
[INFO] Final Memory: 113M/1253M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 8, 2015, 4:19 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
  lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
  lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
  lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
  lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
  lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
[INFO] Lens .............................................. SUCCESS [3.371s]
[INFO] Lens API .......................................... SUCCESS [26.972s]
[INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
[INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
[INFO] Lens DB storage ................................... SUCCESS [33.380s]
[INFO] Lens Query Library ................................ SUCCESS [29.792s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
[INFO] Lens Server ....................................... SUCCESS [4:52.979s]
[INFO] Lens client ....................................... SUCCESS [41.132s]
[INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
[INFO] Lens Examples ..................................... SUCCESS [9.252s]
[INFO] Lens Distribution ................................. SUCCESS [11.228s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
[INFO] Lens Regression ................................... SUCCESS [7.449s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18.026s
[INFO] Finished at: Thu May 07 08:59:21 UTC 2015
[INFO] Final Memory: 113M/1253M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 7, 2015, 3:29 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
  lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
  lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
  lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
  lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
  lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 

Diff: https://reviews.apache.org/r/33581/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s]
[INFO] Lens .............................................. SUCCESS [3.371s]
[INFO] Lens API .......................................... SUCCESS [26.972s]
[INFO] Lens API for server and extensions ................ SUCCESS [36.260s]
[INFO] Lens Cube ......................................... SUCCESS [4:27.436s]
[INFO] Lens DB storage ................................... SUCCESS [33.380s]
[INFO] Lens Query Library ................................ SUCCESS [29.792s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s]
[INFO] Lens Server ....................................... SUCCESS [4:52.979s]
[INFO] Lens client ....................................... SUCCESS [41.132s]
[INFO] Lens CLI .......................................... SUCCESS [3:07.546s]
[INFO] Lens Examples ..................................... SUCCESS [9.252s]
[INFO] Lens Distribution ................................. SUCCESS [11.228s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s]
[INFO] Lens Regression ................................... SUCCESS [7.449s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18.026s
[INFO] Finished at: Thu May 07 08:59:21 UTC 2015
[INFO] Final Memory: 113M/1253M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 7, 2015, 2:22 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa32072952bc43b093e039ff282096d39cc 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c81cf344f16114f0d67f255f9f8f486aecfda957 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 7883b15d5c0c946e29722a6b02e89eb810b36d72 
  lens-examples/src/main/resources/cube-queries.sql 7a0b542a00e27a6a68d94f26b17bba881afadfe4 
  lens-examples/src/main/resources/customer.xml 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e 
  lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml 35a88019c07dd98f4b55c10debb92afe84f85dde 
  lens-examples/src/main/resources/sales-aggr-fact2.xml b535a875300528074d499e11ae545034529bb6e5 
  lens-examples/src/main/resources/sales-cube.xml f5e2f93f50fafd750554d80de15e1a9d2c166b6c 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
[INFO] Lens .............................................. SUCCESS [2.729s]
[INFO] Lens API .......................................... SUCCESS [19.890s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
[INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
[INFO] Lens DB storage ................................... SUCCESS [19.125s]
[INFO] Lens Query Library ................................ SUCCESS [20.968s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
[INFO] Lens Server ....................................... SUCCESS [5:54.523s]
[INFO] Lens client ....................................... SUCCESS [45.558s]
[INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
[INFO] Lens Examples ..................................... SUCCESS [16.021s]
[INFO] Lens Distribution ................................. SUCCESS [17.832s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
[INFO] Lens Regression ................................... SUCCESS [8.135s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:57.456s
[INFO] Finished at: Wed May 06 09:07:01 UTC 2015
[INFO] Final Memory: 115M/1373M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 7, 2015, 11:51 a.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 24d0d6440a7c9156a62aabd8dae6b50ecd5ab253 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
[INFO] Lens .............................................. SUCCESS [2.729s]
[INFO] Lens API .......................................... SUCCESS [19.890s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
[INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
[INFO] Lens DB storage ................................... SUCCESS [19.125s]
[INFO] Lens Query Library ................................ SUCCESS [20.968s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
[INFO] Lens Server ....................................... SUCCESS [5:54.523s]
[INFO] Lens client ....................................... SUCCESS [45.558s]
[INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
[INFO] Lens Examples ..................................... SUCCESS [16.021s]
[INFO] Lens Distribution ................................. SUCCESS [17.832s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
[INFO] Lens Regression ................................... SUCCESS [8.135s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:57.456s
[INFO] Finished at: Wed May 06 09:07:01 UTC 2015
[INFO] Final Memory: 115M/1373M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 6, 2015, 8:01 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 24d0d6440a7c9156a62aabd8dae6b50ecd5ab253 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
[INFO] Lens .............................................. SUCCESS [2.729s]
[INFO] Lens API .......................................... SUCCESS [19.890s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
[INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
[INFO] Lens DB storage ................................... SUCCESS [19.125s]
[INFO] Lens Query Library ................................ SUCCESS [20.968s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
[INFO] Lens Server ....................................... SUCCESS [5:54.523s]
[INFO] Lens client ....................................... SUCCESS [45.558s]
[INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
[INFO] Lens Examples ..................................... SUCCESS [16.021s]
[INFO] Lens Distribution ................................. SUCCESS [17.832s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
[INFO] Lens Regression ................................... SUCCESS [8.135s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:57.456s
[INFO] Finished at: Wed May 06 09:07:01 UTC 2015
[INFO] Final Memory: 115M/1373M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 6, 2015, 2:39 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description (updated)
-------

Allow timed dimensions to be a field and not a time partitioning column.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 25173ebacf0733114593cee2fe0d3c28c6ea2885 

Diff: https://reviews.apache.org/r/33581/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s]
[INFO] Lens .............................................. SUCCESS [2.729s]
[INFO] Lens API .......................................... SUCCESS [19.890s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.948s]
[INFO] Lens Cube ......................................... SUCCESS [3:34.024s]
[INFO] Lens DB storage ................................... SUCCESS [19.125s]
[INFO] Lens Query Library ................................ SUCCESS [20.968s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s]
[INFO] Lens Server ....................................... SUCCESS [5:54.523s]
[INFO] Lens client ....................................... SUCCESS [45.558s]
[INFO] Lens CLI .......................................... SUCCESS [3:46.349s]
[INFO] Lens Examples ..................................... SUCCESS [16.021s]
[INFO] Lens Distribution ................................. SUCCESS [17.832s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s]
[INFO] Lens Regression ................................... SUCCESS [8.135s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:57.456s
[INFO] Finished at: Wed May 06 09:07:01 UTC 2015
[INFO] Final Memory: 115M/1373M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 5, 2015, 8:24 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

posting for early comments.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 25173ebacf0733114593cee2fe0d3c28c6ea2885 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Re: Review Request 33581: LENS:198: Allow timed dimensions of cube to be non-partitioned columns as well

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33581/
-----------------------------------------------------------

(Updated May 5, 2015, 8:05 p.m.)


Review request for lens.


Bugs: LENS-198
    https://issues.apache.org/jira/browse/LENS-198


Repository: lens


Description
-------

posting for early comments.


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 74a26feec12cd3630ab06d8a714ad05fcec9e9ec 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8e2c9ed23670934a76d931ad6eb018bcf203dedf 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 8a533fc949d040477377900ffd4445e35dfe3c80 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java 66467183d4e397257e613668681acb75a10ca92e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java a65bc96f0dbc6d0694e538ece68c7dd38a78a24b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 47b9fc1ed678550d929b234bb6742635390df8ba 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 165525d083f78b1c6a00fec6811efb3549c696b8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b7c3ee95f7275f78b5e87377de59720f1bdd9ade 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java f5d2115d885cc7a88061543267f0d6c49882d884 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java e200b12ae7bcef800c138c0db2b3ceb0d0b028ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java fa23b8e42452552c9d400fcfa20d5d099458ffbc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 766769f64da062ab4417745cdd1ef110fe0bf933 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java ddabc25f7a4c1d6fdc4c272685690600d651176a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a41424a06a904a08b4f0c8ac294a6eebdf7902e6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java fcc611481ae152faaeabb2b6aa4a94f192823359 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java e5a6b32472ec7094459f60d0c7cd16d49a131ba6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 612cdf9b39f82efea0f8197f1daabe4a85994775 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 32033541a822f87e80b8236c6ca2d2e34b99ed6c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 29240b69b990a0b962c2103a30ed87093236ded9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 06de5cdafa705dc6570b42e32b47ad914327700a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 79d9be30de1a270a801cbbaaf1b8b399d4103033 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java bd519716e3069558f634d8dbb0c08b113b66f2d1 
  lens-examples/src/main/resources/sales-cube.xml 951ace98e7872e60395f3c3201ea2ecf8e03d577 

Diff: https://reviews.apache.org/r/33581/diff/


Testing
-------


Thanks,

Rajat Khandelwal