[GitHub] [beam] lukecwik commented on a change in pull request #12880: [BEAM-10933] Adjust GBK and Flatten types before creating the pipeline proto

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #12880:
URL: https://github.com/apache/beam/pull/12880#discussion_r492181015



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -430,6 +430,15 @@ def _check_for_unsupported_fnapi_features(self, pipeline_proto):
                 components.coders[windowing_strategy.window_coder_id].spec.urn,
                 windowing_strategy.window_fn.urn))
 
+  def _adjust_types_for_dataflow(self, pipeline):
+    # Dataflow runner requires a KV type for GBK inputs, hence we enforce that
+    # here.
+    pipeline.visit(self.group_by_key_input_visitor())
+
+    # Dataflow runner requires output type of the Flatten to be the same as the

Review comment:
       @CraigChambersG I was under the impression that this wasn't true and that Dataflow v2 handled this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org