[GitHub] [hive] pgaref commented on a change in pull request #1963: HIVE-24758: Log Tez Task DAG ID, DAG Session ID, HS2 Hostname

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #1963:
URL: https://github.com/apache/hive/pull/1963#discussion_r573796890



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java
##########
@@ -137,6 +139,8 @@ public int execute() {
     Context ctx = null;
     Ref<TezSessionState> sessionRef = Ref.from(null);
 
+    final String queryId = HiveConf.getVar(conf, HiveConf.ConfVars.HIVEQUERYID);

Review comment:
       I would probably move this to Task initialize method and reuse across method -- e.g., build, execute etc

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java
##########
@@ -236,6 +239,10 @@ public int execute() {
           throw new HiveException("Operation cancelled");
         }
 
+        // Log all the info required to find the various logs for this query
+        LOG.info("HS2 Host: [{}], Query ID: [{}], Dag ID: [{}], DAG Session ID: [{}]", getHostNameIP(), queryId,

Review comment:
       I would change that to something like "Executing query with Id {} from dag {} by session {} "
   Not sure I would add the hostName IP here as this can be quite confusing, especially when running mutiple containers on the same node (like kubernetes). Not sure if we already have better info for that on a Task level.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org