You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/05 06:39:15 UTC

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #987: l2cap: implement echo request-response procedure (l2cap ping)

sjanc commented on a change in pull request #987:
URL: https://github.com/apache/mynewt-nimble/pull/987#discussion_r663673032



##########
File path: nimble/host/src/ble_l2cap_sig.c
##########
@@ -1979,6 +1979,9 @@ ble_l2cap_sig_ping(uint16_t conn_handle, ble_l2cap_ping_fn cb,
 
 
     rc = ble_l2cap_sig_tx(proc->conn_handle, txom);
+    if (rc != 0) {

Review comment:
       hmm I think ble_l2cap_sig_tx is (or should) consume txom regardless of result




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org