You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/08 12:13:41 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #15088: [fix][test] Add receive timeout to avoid block thread.
mattisonchao opened a new pull request, #15088:
URL: https://github.com/apache/pulsar/pull/15088
### Motivation
After #12420, we can use `RECEIVE_TIMEOUT_SECONDS` to avoid consumers blocking receiving messages until the Github Action task times out.
### Modifications
- Add timeout when the consumer receives messages.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15088: [fix][test] Add receive timeout to avoid block thread.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15088:
URL: https://github.com/apache/pulsar/pull/15088#issuecomment-1092797540
@lhotari @nicoloboschi PTAL :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15088: [fix][test] Add receive timeout to avoid block thread.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15088:
URL: https://github.com/apache/pulsar/pull/15088#issuecomment-1092892957
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15088: [fix][test] Add receive timeout to avoid block thread.
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15088:
URL: https://github.com/apache/pulsar/pull/15088#issuecomment-1092987630
> /pulsarbot rerun-failure-checks
Please read this information about failed PR checks: https://lists.apache.org/thread/60x7sqg2p4mlssj5jtow6zwq3jksf6w3
It might appear that "/pulsarbot rerun-failure-checks" is broken. That's not the case. The email thread explains it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #15088: [fix][test] Add receive timeout to avoid block thread.
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15088:
URL: https://github.com/apache/pulsar/pull/15088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] horizonzy commented on pull request #15088: [fix][test] Add receive timeout to avoid block thread.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #15088:
URL: https://github.com/apache/pulsar/pull/15088#issuecomment-1113521990
Hi, This change make test unstable. If use `receive(int timeout, TimeUnit unit)` here, it maybe return `null`.
see:
https://github.com/apache/pulsar/blob/2ddef95f31ce37486f3f76b4d59730361a77bf6e/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L489-L492
In the tests code:
https://github.com/apache/pulsar/blob/2ddef95f31ce37486f3f76b4d59730361a77bf6e/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java#L2477-L2486
The code will into `else branch`(line_2484). So the consumer can't receive all messages.
The assert will failed.
https://github.com/apache/pulsar/blob/2ddef95f31ce37486f3f76b4d59730361a77bf6e/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java#L2487
We ofter found flaky tests failed recently.
There is a test result to prove it.
see:
https://github.com/apache/pulsar/issues/10117#issuecomment-1113297053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org