You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by dz...@apache.org on 2021/09/17 08:53:39 UTC
[drill] 05/09: Remove individual module build commands.
This is an automated email from the ASF dual-hosted git repository.
dzamo pushed a commit to branch 7999-docker-jdk
in repository https://gitbox.apache.org/repos/asf/drill.git
commit f95f8b199b072212cb408e2feffa62bb3cbdcdae
Author: James Turton <ja...@somecomputer.xyz>
AuthorDate: Thu Sep 16 15:36:58 2021 +0200
Remove individual module build commands.
I had hoped these module build layers would be an optimisation but
I now think they result in Maven doing rework rather than building
incrementally.
---
Dockerfile | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/Dockerfile b/Dockerfile
index 51e5423..6cf8c48 100755
--- a/Dockerfile
+++ b/Dockerfile
@@ -33,19 +33,6 @@ WORKDIR /src
# Copy project sources into the container
COPY . .
-# Optimisation: build a selection of Drill modules in advance.
-# It isn't necessary to build any modules independently but doing so divides
-# the downloading and compiling up over multiple cacheable layers, better
-# enabling reuse in the event of an isolated change and resume in the event
-# of a build error. This paragraph can safely be commented out.
-RUN mvn -am -pl tools -Dmaven.artifact.threads=5 -T1C install -DskipTests
-RUN mvn -am -pl protocol -Dmaven.artifact.threads=5 -T1C install -DskipTests
-RUN mvn -am -pl common -Dmaven.artifact.threads=5 -T1C install -DskipTests
-RUN mvn -am -pl logical -Dmaven.artifact.threads=5 -T1C install -DskipTests
-RUN mvn -am -pl exec -Dmaven.artifact.threads=5 -T1C install -DskipTests
-RUN mvn -am -pl drill-yarn -Dmaven.artifact.threads=5 -T1C install -DskipTests
-RUN mvn -am -pl distribution -Dmaven.artifact.threads=5 -T1C install -DskipTests
-
# Builds Drill
RUN mvn -Dmaven.artifact.threads=5 -T1C install -DskipTests