[GitHub] [orc] guiyanakuang commented on a diff in pull request #1166: ORC-1205: Size of batches in some ConvertTreeReaders should be ensured before using

[GitBox <gi...@apache.org>]

guiyanakuang commented on code in PR #1166:
URL: https://github.com/apache/orc/pull/1166#discussion_r905923547


##########
java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java:
##########
@@ -1764,6 +1812,9 @@ public void nextVector(ColumnVector previousVector,
                                                    " proleptic Gregorian dates.");
           }
         }
+      } else {
+        bytesColVector.ensureSize(batchSize, false);
+        dateColumnVector.ensureSize(batchSize, false);

Review Comment:
   `dateColumnVector.ensureSize(batchSize, false);` may throw a null pointer exception and we may need to check additionally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org