You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2017/05/26 09:34:04 UTC

[jira] [Commented] (SOLR-10741) Create a new method to get slice shards string in HttpShardHandler

    [ https://issues.apache.org/jira/browse/SOLR-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026061#comment-16026061 ] 

Christine Poerschke commented on SOLR-10741:
--------------------------------------------

The HttpShardHandler.prepDistributed method is currently very long i.e. https://github.com/apache/lucene-solr/blob/2fc41d565a4a0408a09856a37d3be7d87414ba3f/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java#L278-L473 and complex, so +1 to breaking it up.

> Create a new method to get slice shards string in HttpShardHandler
> ------------------------------------------------------------------
>
>                 Key: SOLR-10741
>                 URL: https://issues.apache.org/jira/browse/SOLR-10741
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Domenico Fabio Marino
>            Priority: Minor
>         Attachments: SOLR-10741.patch
>
>
> Extract a method called getSliceShardsStr from prepDistributed() in HttpShardHandler.java.
> This method takes a list of shard URLs and concatenates them into a String, and then returns the String. 
> This could allow to perform some more refactoring in the future



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org