You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/30 06:22:34 UTC
[GitHub] [calcite] hsyuan commented on a change in pull request #1546:
[CALCITE-3458] Remove desc in AbstractRelNode
hsyuan commented on a change in pull request #1546: [CALCITE-3458] Remove desc in AbstractRelNode
URL: https://github.com/apache/calcite/pull/1546#discussion_r340445669
##########
File path: core/src/main/java/org/apache/calcite/rel/AbstractRelNode.java
##########
@@ -363,11 +352,14 @@ public void replaceInput(
}
public String toString() {
- return desc;
+ return getDescription();
}
+ /* Description, consists of id plus digest */
public final String getDescription() {
- return desc;
+ StringBuilder sb = new StringBuilder("rel#");
+ sb = sb.append(id).append(':').append(digest);
+ return sb.toString();
Review comment:
Yes. That is expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services