[jira] [Commented] (AIRFLOW-4187) Slack Webhook Operator do not pass conn_id to its parent class

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815390#comment-16815390 ] 

ASF GitHub Bot commented on AIRFLOW-4187:
-----------------------------------------

bryanyang0528 commented on pull request #5004: [AIRFLOW-4187] SlackWebhookOperator do not pass http_conn_id to its parent class
URL: https://github.com/apache/airflow/pull/5004
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Slack Webhook Operator do not pass conn_id to its parent class
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-4187
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4187
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Bryan Yang
>            Assignee: Bryan Yang
>            Priority: Major
>
> {{SlackWebhookOperator}} inherits from {{HttpHook}}. HttpHook will find the conn.host by http_conn_id, but {{SlackWebhookOperator}} didn't pass http_conn_id to HttpHook so that HttpHook always use it default value `http_default` to get the host like this:
> bq. [2019-03-29 10:23:21,444] {base_hook.py:83} INFO - Using connection to: id: http_default. Host: https://www.google.com/, Port: None, Schema: None, Login: None, Password: None, extra: {}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)