You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:43:10 UTC
[GitHub] [airflow] kazanzhy opened a new pull request #22125: AWS RDS integration fixes
kazanzhy opened a new pull request #22125:
URL: https://github.com/apache/airflow/pull/22125
AWS RDS integration fixes for:
https://github.com/apache/airflow/pull/20642
https://github.com/apache/airflow/pull/20907
https://github.com/apache/airflow/pull/21231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #22125:
URL: https://github.com/apache/airflow/pull/22125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy edited a comment on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy edited a comment on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064638514
My bad. That's my own bug that I have put to `moto`.
Fixing it by this PR https://github.com/spulec/moto/pull/4930
Also, since I started implementing this integration `@mock_rds2` become deprecated and all functionality is available in `@mock_rds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1066113634
Updated constraints manually. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1066075673
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy edited a comment on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy edited a comment on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064638514
My bad. That's my own bug that I've put to `moto`.
Fixing it by this PR https://github.com/spulec/moto/pull/4930
Also, since I started implementing this integration `@mock_rds2` become deprecated and all functionality is available in `@mock_rds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22125:
URL: https://github.com/apache/airflow/pull/22125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1063175841
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy edited a comment on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy edited a comment on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064638514
My bad. That's my own bug that I had put to `moto`.
Fixing it by this PR https://github.com/spulec/moto/pull/4930
Also, since I started implementing this integration `@mock_rds2` become deprecated and all functionality is available in `@mock_rds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1065989260
A new `moto` version was released recently.
So I can say that operators work as expected with real AWS and `moto` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064490464
rds tests are failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy edited a comment on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy edited a comment on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064638514
My bad.
That's my own bug that I have put to `moto`.
Fixing it by this PR https://github.com/spulec/moto/pull/4930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064636873
Yeah will need to wait for amazon release for that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy edited a comment on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy edited a comment on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064638514
Yeap. That's my own bug that I put to `moto`.
Fixing it https://github.com/spulec/moto/pull/4930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy commented on pull request #22125: AWS RDS integration fixes
Posted by GitBox <gi...@apache.org>.
kazanzhy commented on pull request #22125:
URL: https://github.com/apache/airflow/pull/22125#issuecomment-1064638514
Yeap. That's my own bug that I put to `moto`. Fixing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org