[GitHub] [solr] dweiss commented on a diff in pull request #1320: SOLR-16641 - Fix circular task dependency for gradle.properties

["dweiss (via GitHub)" <gi...@apache.org>]

dweiss commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1092015488


##########
gradle/validation/jar-checks.gradle:
##########
@@ -313,7 +313,9 @@ configure(plist) {
       .collectMany { task -> [task, task.dependsOn]}
       .flatten()
       .each { task ->
-        task.mustRunAfter updateLicenses
+        if (task.name != 'localSettings') {

Review Comment:
   Perhaps use the full path here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org