You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan Ernst (JIRA)" <ji...@apache.org> on 2014/10/08 01:40:34 UTC
[jira] [Updated] (LUCENE-5999) Add backcompat support for
StandardTokenizer before 4.7
[ https://issues.apache.org/jira/browse/LUCENE-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Ernst updated LUCENE-5999:
-------------------------------
Attachment: LUCENE-5999.patch
Here's a patch which adds back support in the same way other backcompat is done: with a copy of the old code and versioning in the class name. This is different than was done before, but it makes it so we don't have to have Version based constructors, and we don't have possibility of some other impl detail changing in StandardTokenizer itself that could silently break compat.
The only thing I'm not happy about with this patch is having to add AbstractStandardTokenizer so that setMaxTokenLength could be available for both impls. If someone has an idea for a cleaner approach, I'm happy to drop that.
> Add backcompat support for StandardTokenizer before 4.7
> -------------------------------------------------------
>
> Key: LUCENE-5999
> URL: https://issues.apache.org/jira/browse/LUCENE-5999
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ryan Ernst
> Attachments: LUCENE-5999.patch
>
>
> The merge from trunk for branch_5x remove the backcompat support in StandardTokenizer for previous unicode versions. With 5x, we only need to add support back for 4.0-4.6 (unicode 6.1).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org