You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Chris Darroch (JIRA)" <ji...@apache.org> on 2009/07/14 20:11:15 UTC
[jira] Created: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
make sure CPPUNIT_CFLAGS isn't overwritten
------------------------------------------
Key: ZOOKEEPER-469
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.2.0
Reporter: Chris Darroch
Fix For: 3.2.1
Attachments: ZOOKEEPER-469.patch
When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-469:
------------------------------------
Fix Version/s: 3.3.0
Assignee: Chris Darroch
+1 to the patch. I will commit it to both 3.2.1 and trunk.
> make sure CPPUNIT_CFLAGS isn't overwritten
> ------------------------------------------
>
> Key: ZOOKEEPER-469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0
> Reporter: Chris Darroch
> Assignee: Chris Darroch
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-469.patch
>
>
> When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-469:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> make sure CPPUNIT_CFLAGS isn't overwritten
> ------------------------------------------
>
> Key: ZOOKEEPER-469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0
> Reporter: Chris Darroch
> Assignee: Chris Darroch
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-469.patch
>
>
> When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-469:
------------------------------------
I just committed this to trunk and 3.2.1. thanks chris.
> make sure CPPUNIT_CFLAGS isn't overwritten
> ------------------------------------------
>
> Key: ZOOKEEPER-469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0
> Reporter: Chris Darroch
> Assignee: Chris Darroch
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-469.patch
>
>
> When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Darroch updated ZOOKEEPER-469:
------------------------------------
Attachment: ZOOKEEPER-469.patch
> make sure CPPUNIT_CFLAGS isn't overwritten
> ------------------------------------------
>
> Key: ZOOKEEPER-469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0
> Reporter: Chris Darroch
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-469.patch
>
>
> When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735504#action_12735504 ]
Hudson commented on ZOOKEEPER-469:
----------------------------------
Integrated in ZooKeeper-trunk #393 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/393/])
> make sure CPPUNIT_CFLAGS isn't overwritten
> ------------------------------------------
>
> Key: ZOOKEEPER-469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0
> Reporter: Chris Darroch
> Assignee: Chris Darroch
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-469.patch
>
>
> When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-469) make sure CPPUNIT_CFLAGS isn't
overwritten
Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Darroch updated ZOOKEEPER-469:
------------------------------------
Status: Patch Available (was: Open)
I've pulled this from ZOOKEEPER-316 because it was getting lost there, I think, and is technically unrelated to the problem first reported there. This should be a much more straightforward fix for a problem that doesn't relate to any licensing issues for cppunit, for example. Sorry for any confusion.
> make sure CPPUNIT_CFLAGS isn't overwritten
> ------------------------------------------
>
> Key: ZOOKEEPER-469
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-469
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0
> Reporter: Chris Darroch
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-469.patch
>
>
> When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.