[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

[GitBox <gi...@apache.org>]

gerlowskija commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r441907028



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java
##########
@@ -491,6 +490,11 @@ public boolean equals(Object o) {
       return this == o;
     }
 
+    @Override

Review comment:
       As someone who has at least a passing understanding of this code, this and the other Streaming class implementations below gets my +1.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org