[GitHub] [flink] absurdfarce commented on a diff in pull request #19586: [FLINK-26824] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions

[GitBox <gi...@apache.org>]

absurdfarce commented on code in PR #19586:
URL: https://github.com/apache/flink/pull/19586#discussion_r895920666


##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -36,9 +36,11 @@ under the License.
 
 	<!-- Allow users to pass custom connector versions -->
 	<properties>
-		<cassandra.version>2.2.5</cassandra.version>
-		<driver.version>3.0.0</driver.version>
-		<guava.version>18.0</guava.version>
+		<!-- Cassandra version 4.x allow to address clusters of version 3.x as well -->
+		<cassandra.version>4.0.3</cassandra.version>
+		<!--driver 3.x works with 3.x and 4.x versions of Cassandra but driver 4.x is a complete refactoring with different API-->
+		<driver.version>3.11.2</driver.version>

Review Comment:
   You should be able to safely exclude the jnr-ffi and jnr-posix dependencies.  The driver uses jnr-posix to access native calls for two optimizations (easy access to the PID + microsecond timestamp precision), both of which are indeed optional (the driver will detect their absence and has non-native fallbacks available for both cases).  You'll get debug-level slf4j stack traces but that should be the worst consequence.
   
   The jackson-databind dependency is used for parsing an XML config in the Astra connectivity code.  This can also be excluded for the non-Astra case (which presumably is the default).
   
   A hearty 👍 to the use of the shaded JAR as well.
   
   I have a simple test app that builds and runs without issue using the following Gradle dependency:
   
   ```
       compile('com.datastax.cassandra:cassandra-driver-core:3.11.2:shaded') {
           exclude group:'io.netty', module:'netty-handler'
           exclude group:'com.github.jnr', module:'jnr-ffi'
           exclude group:'com.github.jnr', module:'jnr-posix'
           exclude group:'com.fasterxml.jackson.core', module:'jackson-databind'
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org