[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #589: MINIFICPP-914: Incur wait while awaiting minifi shutdown during restart

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #589: MINIFICPP-914: Incur wait while awaiting minifi shutdown during restart
URL: https://github.com/apache/nifi-minifi-cpp/pull/589#discussion_r292335649
 
 

 ##########
 File path: bin/minifi.sh
 ##########
 @@ -252,7 +252,12 @@ case "\$1" in
     restart)
         echo Restarting MiNiFi service
         \${bin_dir}/minifi.sh stop
-        \${bin_dir}/minifi.sh start
+	if [ "${saved_pid}" -gt 0 ]; then
+	        while [ $(active_pid ${saved_pid}) -eq 0 ]; do
 
 Review comment:
   Wonder if a timeout makes sense here. (If there is any chance for MiNiFi to get stuck during shutdown)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services