You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/14 16:36:47 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #39061: [WIP][SPARK-41518][SQL] Assign a name to the error class `_LEGACY_ERROR_TEMP_2422`

MaxGekk commented on code in PR #39061:
URL: https://github.com/apache/spark/pull/39061#discussion_r1048703232


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,6 +496,11 @@
     ],
     "sqlState" : "42000"
   },
+  "GROUPING_EXPRESSIONS_NOT_FOUND" : {
+    "message" : [
+      "Not found any GROUP BY expressions, and <sqlExpr> is not an aggregate function. Wrap <aggExprs> by windowing function(s) or wrap <sqlExpr> by `first()` (or `first_value()`) if you don't care which value you get."
+    ]
+  },

Review Comment:
   > My money is on forgetting the GROUP BY clause....
   
   Highly likely, you are right. Let me following your proposal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org