[GitHub] [pulsar] shy-share commented on a diff in pull request #19434: [Cli tools] Add command line option for configuring the memory limit

["shy-share (via GitHub)" <gi...@apache.org>]

shy-share commented on code in PR #19434:
URL: https://github.com/apache/pulsar/pull/19434#discussion_r1102162185


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/PulsarClientTool.java:
##########
@@ -76,6 +76,9 @@ public static class RootParams {
 
         @Parameter(names = { "--tlsTrustCertsFilePath" }, description = "File path to client trust certificates")
         String tlsTrustCertsFilePath;
+
+        @Parameter(names = { "-m", "--memory", }, description = "Configure the Pulsar client memory limit")
+        Long memory=0L;

Review Comment:
   Do you think it should be changed to this ？
   
   @Parameter(names = { "-M", "--Memory", },



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org