[jira] [Commented] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362115#comment-16362115 ] 

Ted Yu commented on HBASE-19979:
--------------------------------

+1

> ReplicationSyncUp tool may leak Zookeeper connection
> ----------------------------------------------------
>
>                 Key: HBASE-19979
>                 URL: https://issues.apache.org/jira/browse/HBASE-19979
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 1.5.0
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Major
>         Attachments: HBASE-19979-branch-1.001.patch
>
>
> ReplicationSyncUp tool may leak Zookeeper connection in the following code snippet,
> {code}
>     try {
>       int numberOfOldSource = 1; // default wait once
>       while (numberOfOldSource > 0) {
>         Thread.sleep(SLEEP_TIME);
>         numberOfOldSource = manager.getOldSources().size();
>       }
>     } catch (InterruptedException e) {
>       System.err.println("didn't wait long enough:" + e);
>       return (-1);
>     }
>     manager.join();
>     zkw.close();
> {code}
> ZooKeeperWatcher will not be closed in case of InterruptedException.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)