You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/20 22:08:56 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24464: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans

dongjoon-hyun edited a comment on issue #24464: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans
URL: https://github.com/apache/spark/pull/24464#issuecomment-494167695
 
 
   Thank you, @gatorsmile and @hvanhovell .
   @gatorsmile also gave the regression example about `explain on EXPLAIN` statement. Even a simple example like the following, the output is a huge mess.
   ```scala
   scala> sql("explain select 1").explain(true)
   == Parsed Logical Plan ==
   ExplainCommand == Parsed Logical Plan ==
   'Project [unresolvedalias(1, None)]
   +- OneRowRelation
   
   == Analyzed Logical Plan ==
   1: int
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Optimized Logical Plan ==
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Physical Plan ==
   *(1) Project [1 AS 1#2]
   +- *(1) Scan OneRowRelation[]
   , false, false, false
   
   == Analyzed Logical Plan ==
   plan: string
   ExplainCommand == Parsed Logical Plan ==
   'Project [unresolvedalias(1, None)]
   +- OneRowRelation
   
   == Analyzed Logical Plan ==
   1: int
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Optimized Logical Plan ==
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Physical Plan ==
   *(1) Project [1 AS 1#2]
   +- *(1) Scan OneRowRelation[]
   , false, false, false
   
   == Optimized Logical Plan ==
   ExplainCommand == Parsed Logical Plan ==
   'Project [unresolvedalias(1, None)]
   +- OneRowRelation
   
   == Analyzed Logical Plan ==
   1: int
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Optimized Logical Plan ==
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Physical Plan ==
   *(1) Project [1 AS 1#2]
   +- *(1) Scan OneRowRelation[]
   , false, false, false
   
   == Physical Plan ==
   Execute ExplainCommand
      +- ExplainCommand == Parsed Logical Plan ==
   'Project [unresolvedalias(1, None)]
   +- OneRowRelation
   
   == Analyzed Logical Plan ==
   1: int
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Optimized Logical Plan ==
   Project [1 AS 1#2]
   +- OneRowRelation
   
   == Physical Plan ==
   *(1) Project [1 AS 1#2]
   +- *(1) Scan OneRowRelation[]
   , false, false, false
   ```
   
   Sorry about this mess. I'll revert this. @viirya . Please proceed with @hvanhovell 's advice~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org