You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/13 09:37:50 UTC
[GitHub] [pulsar] freeznet opened a new pull request #11666: [pulsar-admin] allow create functions with package URL
freeznet opened a new pull request #11666:
URL: https://github.com/apache/pulsar/pull/11666
Fix https://github.com/apache/pulsar/issues/11665
### Motivation
Allow user to create function with package URL with pulsar-admin.
### Modifications
- allow passing valid package URL from pulsar-admin functions
- added tests
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
#### For contributor
For this PR, do we need to update docs?
- If yes, please update docs or create a follow-up issue if you need help.
- If no, please explain why.
#### For committer
For this PR, do we need to update docs?
- If yes,
- if you update docs in this PR, label this PR with the `doc` label.
- if you plan to update docs later, label this PR with the `doc-required` label.
- if you need help on updating docs, create a follow-up issue with the `doc-required` label.
- If no, label this PR with the `no-need-doc` label and explain why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #11666: [pulsar-admin] allow create functions with package URL
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #11666:
URL: https://github.com/apache/pulsar/pull/11666#discussion_r689277408
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/functions/Utils.java
##########
@@ -34,7 +36,9 @@
public static boolean isFunctionPackageUrlSupported(String functionPkgUrl) {
return isNotBlank(functionPkgUrl) && (functionPkgUrl.startsWith(HTTP)
- || functionPkgUrl.startsWith(FILE));
+ || functionPkgUrl.startsWith(FILE)
+ || Arrays.stream(PackageType.values()).anyMatch(type -> functionPkgUrl.startsWith(type.toString()))
Review comment:
can we create an utility method ? this code looks duplicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11666: [pulsar-admin] allow create functions with package URL
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11666:
URL: https://github.com/apache/pulsar/pull/11666#issuecomment-899143799
@freeznet thanks for your contribution! When can we start updating docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #11666: [pulsar-admin] allow create functions with package URL
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11666:
URL: https://github.com/apache/pulsar/pull/11666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11666: [pulsar-admin] allow create functions with package URL
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11666:
URL: https://github.com/apache/pulsar/pull/11666#issuecomment-899903588
> @Anonymitaet thanks, we can start the doc once this PR is merged.
@freeznet please ping me if you submit a doc PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #11666: [pulsar-admin] allow create functions with package URL
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #11666:
URL: https://github.com/apache/pulsar/pull/11666#issuecomment-899147681
@Anonymitaet thanks, we can start the doc once this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org