You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 21:52:39 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

rkhachatryan opened a new pull request #12258:
URL: https://github.com/apache/flink/pull/12258


   ## What is the purpose of the change
   
   See FLINK-17820 for full problem description. In short, Flink ignores `state.backend.fs.memory-threshold` and always creates a file per subtask per checkpoint.
   
   This PR wraps `OutputStream` in `ChannelStateWriter` into a non-flushing one; so that data can be flushed from `DataOutputStream`, but not to disk.
   This solution was chosen:
   - over changing the original stream because of lower risk
   - over not flushing in `ChannelStateWriter` because that could lead to data loss in `DataOutputStream`
   
   ## Verifying this change
   
   Added `ChannelStateCheckpointWriterTest.testSmallFilesNotWritten`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicabl
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-632589001


   build failure is unrelated: https://issues.apache.org/jira/browse/FLINK-17817


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631108764


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf629e225bc323888017be5d5a86c7c89a2b76bd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631104634


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8d01ba80d36c07517d7493cef13d6ab634c01e18 (Fri Oct 16 10:55:21 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-633844876


   Obsoleted by #12332


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631108764


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892",
       "triggerID" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf629e225bc323888017be5d5a86c7c89a2b76bd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan closed pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
rkhachatryan closed pull request #12258:
URL: https://github.com/apache/flink/pull/12258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631108764


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892",
       "triggerID" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8d01ba80d36c07517d7493cef13d6ab634c01e18",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1909",
       "triggerID" : "8d01ba80d36c07517d7493cef13d6ab634c01e18",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf629e225bc323888017be5d5a86c7c89a2b76bd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892) 
   * 8d01ba80d36c07517d7493cef13d6ab634c01e18 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1909) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631104634


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit cf629e225bc323888017be5d5a86c7c89a2b76bd (Tue May 19 21:55:32 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631108764


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892",
       "triggerID" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf629e225bc323888017be5d5a86c7c89a2b76bd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631108764


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892",
       "triggerID" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8d01ba80d36c07517d7493cef13d6ab634c01e18",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1909",
       "triggerID" : "8d01ba80d36c07517d7493cef13d6ab634c01e18",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8d01ba80d36c07517d7493cef13d6ab634c01e18 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1909) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631108764


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892",
       "triggerID" : "cf629e225bc323888017be5d5a86c7c89a2b76bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8d01ba80d36c07517d7493cef13d6ab634c01e18",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8d01ba80d36c07517d7493cef13d6ab634c01e18",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf629e225bc323888017be5d5a86c7c89a2b76bd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1892) 
   * 8d01ba80d36c07517d7493cef13d6ab634c01e18 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #12258: [FLINK-17820][task][checkpointing] Don't flush channel state to disk explicitly

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12258:
URL: https://github.com/apache/flink/pull/12258#issuecomment-631766209


   I left some comments on the jira issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org