You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/17 01:57:14 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10351: chore: enable no-static-element-interactions eslint rule
etr2460 opened a new pull request #10351:
URL: https://github.com/apache/incubator-superset/pull/10351
### SUMMARY
Keeping my promise from https://github.com/apache/incubator-superset/pull/10275#discussion_r455311638
All these instances seemed to be acting as buttons, so i added `role="button"` to all of them. If someone thinks they're something else from this list (https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md#case-this-element-acts-like-a-button-link-menuitem-etc) I'm happy to update here
### TEST PLAN
CI, main functionality still works
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @graceguo-supercat @nytai @ktmud @suddjian
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10351: chore: enable no-static-element-interactions eslint rule
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10351:
URL: https://github.com/apache/incubator-superset/pull/10351#issuecomment-659787107
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=h1) Report
> Merging [#10351](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0eee6785a812cfa65276cd2bfbef08da8ff357f3&el=desc) will **increase** coverage by `4.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10351 +/- ##
==========================================
+ Coverage 65.67% 69.71% +4.04%
==========================================
Files 601 196 -405
Lines 32268 18946 -13322
Branches 3275 0 -3275
==========================================
- Hits 21191 13209 -7982
+ Misses 10893 5737 -5156
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `69.71% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.44% <0.00%> (-2.23%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `61.32% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.98% <0.00%> (-0.29%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=footer). Last update [0eee678...f26ade0](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10351: chore: enable no-static-element-interactions eslint rule
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10351:
URL: https://github.com/apache/incubator-superset/pull/10351#issuecomment-659787107
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=h1) Report
> Merging [#10351](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0eee6785a812cfa65276cd2bfbef08da8ff357f3&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10351 +/- ##
==========================================
- Coverage 65.67% 65.54% -0.13%
==========================================
Files 601 601
Lines 32268 32259 -9
Branches 3275 3275
==========================================
- Hits 21191 21144 -47
- Misses 10893 10931 +38
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.60% <0.00%> (ø)` | |
| #python | `69.71% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLmpzeA==) | `63.36% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `82.75% <ø> (ø)` | |
| [superset-frontend/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3guanN4) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `34.84% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `57.44% <ø> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `62.96% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `66.66% <ø> (ø)` | |
| [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | `86.36% <ø> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=footer). Last update [0eee678...f26ade0](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10351: chore: enable no-static-element-interactions eslint rule
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10351:
URL: https://github.com/apache/incubator-superset/pull/10351#issuecomment-659787107
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=h1) Report
> Merging [#10351](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0eee6785a812cfa65276cd2bfbef08da8ff357f3&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10351 +/- ##
==========================================
- Coverage 65.67% 65.64% -0.03%
==========================================
Files 601 601
Lines 32268 32259 -9
Branches 3275 3275
==========================================
- Hits 21191 21176 -15
- Misses 10893 10899 +6
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.60% <0.00%> (ø)` | |
| #python | `69.88% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLmpzeA==) | `63.36% <ø> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `82.75% <ø> (ø)` | |
| [superset-frontend/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3guanN4) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `34.84% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `57.44% <ø> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `62.96% <ø> (ø)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `66.66% <ø> (ø)` | |
| [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | `86.36% <ø> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/10351/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=footer). Last update [0eee678...f26ade0](https://codecov.io/gh/apache/incubator-superset/pull/10351?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10351: chore: enable no-static-element-interactions eslint rule
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10351:
URL: https://github.com/apache/incubator-superset/pull/10351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org