You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:17:03 UTC
[GitHub] [flink] wanglijie95 opened a new pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
wanglijie95 opened a new pull request #14416:
URL: https://github.com/apache/flink/pull/14416
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix the error doc in `KubernetesHaServices`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747842855
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit baee37d34012ad05bf5414ab9b6a81cfe19f881a (Fri Dec 18 03:19:54 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14416:
URL: https://github.com/apache/flink/pull/14416#discussion_r545571110
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesHaServices.java
##########
@@ -42,7 +42,7 @@
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
- * An implementation of the {@link AbstractHaServices} using Apache ZooKeeper.
+ * An implementation of the {@link AbstractHaServices} based on kubernetes API.
Review comment:
```suggestion
* An implementation of the {@link AbstractHaServices} using Kubernetes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844012
cc @wangyang0918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998",
"triggerID" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"triggerType" : "PUSH"
}, {
"hash" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baee37d34012ad05bf5414ab9b6a81cfe19f881a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998)
* 44ff90598896340971c0ebe1a8e89715c5bcdfdb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998",
"triggerID" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"triggerType" : "PUSH"
}, {
"hash" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11007",
"triggerID" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44ff90598896340971c0ebe1a8e89715c5bcdfdb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11007)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baee37d34012ad05bf5414ab9b6a81cfe19f881a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998",
"triggerID" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baee37d34012ad05bf5414ab9b6a81cfe19f881a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998",
"triggerID" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"triggerType" : "PUSH"
}, {
"hash" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11007",
"triggerID" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baee37d34012ad05bf5414ab9b6a81cfe19f881a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998)
* 44ff90598896340971c0ebe1a8e89715c5bcdfdb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11007)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #14416:
URL: https://github.com/apache/flink/pull/14416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a change in pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on a change in pull request #14416:
URL: https://github.com/apache/flink/pull/14416#discussion_r545607574
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesHaServices.java
##########
@@ -42,7 +42,7 @@
import static org.apache.flink.util.Preconditions.checkNotNull;
/**
- * An implementation of the {@link AbstractHaServices} using Apache ZooKeeper.
+ * An implementation of the {@link AbstractHaServices} based on kubernetes API.
Review comment:
Thanks for review. I have modified according to your suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-747844139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998",
"triggerID" : "baee37d34012ad05bf5414ab9b6a81cfe19f881a",
"triggerType" : "PUSH"
}, {
"hash" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11007",
"triggerID" : "44ff90598896340971c0ebe1a8e89715c5bcdfdb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baee37d34012ad05bf5414ab9b6a81cfe19f881a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10998)
* 44ff90598896340971c0ebe1a8e89715c5bcdfdb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11007)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14416: [hotfix][k8s] Fix k8s ha service doc.
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14416:
URL: https://github.com/apache/flink/pull/14416#issuecomment-749304594
cc @xintongsong could you help with merging this fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org