You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Yuanhao Luo (Code Review)" <ge...@cloudera.org> on 2016/09/01 07:33:21 UTC
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
Yuanhao Luo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4195
Change subject: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
......................................................................
IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
---
M fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
M testdata/bin/run-hive-server.sh
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
3 files changed, 15 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/4195/1
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Yuanhao Luo (Code Review)" <ge...@cloudera.org>.
Yuanhao Luo has uploaded a new patch set (#2).
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
IMPALA-4056: Fix toSql() of DistributeParam
This commit fix two issues in toSql() of DistributeParam:
1. string literals were not quoted
2. range partition split rows were not printed.
Besides, this commit fix a small issue in run-hive-server.sh
Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
---
M fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
M testdata/bin/run-hive-server.sh
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
3 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/4195/2
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4195/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
Fix toSql() of DistributeParam
(remove the "doesn't work ..." part)
Line 8:
Add a brief description of what was broken. Looks like there were two issues: String literals were not quoted and the range partition split rows were not printed.
http://gerrit.cloudera.org:8080/#/c/4195/1/fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
File fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java:
Line 173: if (rangeElement instanceof StringLiteral) {
you can use rangeElement.toSql() instead
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Yuanhao Luo (Code Review)" <ge...@cloudera.org>.
Yuanhao Luo has uploaded a new patch set (#3).
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
IMPALA-4056: Fix toSql() of DistributeParam
This commit fixes two issues in toSql() of DistributeParam:
1. string literals were not quoted
2. range partition split rows were not printed.
Besides, this commit fixes a small issue in run-hive-server.sh
Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
---
M fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M testdata/bin/run-hive-server.sh
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
4 files changed, 22 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/4195/3
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
Patch Set 3: Code-Review+2
Thanks for your contribution!
Matt, please merge the change.
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
Patch Set 2:
(4 comments)
Thanks for the quick turnaround, almost done.
http://gerrit.cloudera.org:8080/#/c/4195/2//COMMIT_MSG
Commit Message:
Line 9: This commit fix two issues in toSql() of DistributeParam:
fixes
Line 12: Besides, this commit fix a small issue in run-hive-server.sh
fixes
http://gerrit.cloudera.org:8080/#/c/4195/2/fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
File fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java:
Line 173: rangeElementStrings.add((rangeElement.toSqlImpl()));
remove extra parens, also use toSql() instead of toSqlImpl()
http://gerrit.cloudera.org:8080/#/c/4195/2/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test:
Line 41: -- Test error handling for split rows with too many components
Remove this end-to-end test and make an analyzer test instead. See AnalyzeDDLTest.java TestCreateKuduTable()
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Yuanhao Luo (Code Review)" <ge...@cloudera.org>.
Yuanhao Luo has posted comments on this change.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4195/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-4056: Fix toSql() of DistributeParam doesn't work as expected.
> Fix toSql() of DistributeParam
Done
Line 8:
> Add a brief description of what was broken. Looks like there were two issue
Done
http://gerrit.cloudera.org:8080/#/c/4195/1/fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
File fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java:
Line 173: if (rangeElement instanceof StringLiteral) {
> you can use rangeElement.toSql() instead
Done
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4056: Fix toSql() of DistributeParam
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4056: Fix toSql() of DistributeParam
......................................................................
IMPALA-4056: Fix toSql() of DistributeParam
This commit fixes two issues in toSql() of DistributeParam:
1. string literals were not quoted
2. range partition split rows were not printed.
Besides, this commit fixes a small issue in run-hive-server.sh
Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Reviewed-on: http://gerrit.cloudera.org:8080/4195
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/com/cloudera/impala/analysis/DistributeParam.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M testdata/bin/run-hive-server.sh
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
4 files changed, 22 insertions(+), 22 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, but someone else must approve
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I984a63a24f02670347b0e1efceb864d265d1f931
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yuanhao Luo <lu...@software.ict.ac.cn>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <lu...@software.ict.ac.cn>