You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/18 01:31:10 UTC
[GitHub] [superset] suddjian opened a new issue #13193: [Superset SPA] Change frontend code that depends on the url
suddjian opened a new issue #13193:
URL: https://github.com/apache/superset/issues/13193
Once Superset is a Single Page App, we should try to change code that uses `window.location` to use the tools in `react-router` instead.
`window.location` is referenced 71 times in 45 files in the Superset repo. Most of these can probably change to use the location from react-router, but some might be trickier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian closed issue #13193: [Superset SPA] Change frontend code that depends on the url
Posted by GitBox <gi...@apache.org>.
suddjian closed issue #13193:
URL: https://github.com/apache/superset/issues/13193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on issue #13193: [Superset SPA] Change frontend code that depends on the url
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #13193:
URL: https://github.com/apache/superset/issues/13193#issuecomment-824318761
Closing this as part of issue cleanup, but keeping it in the SPA project tracker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org