You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/16 00:26:04 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #5521: Fix TOclient topologies path
rob05c opened a new pull request #5521:
URL: https://github.com/apache/trafficcontrol/pull/5521
Fixes the TO cilent's topologies GetTopologiesWithHdr path, which got missed in the `/api/` removal.
Incidentally, this was discovered with the new ORT Integration Test Framework.
Includes a test for GetTopologiesWithHdr (one didn't exist before, which is how it got missed).
No docs, no interface change.
No changelog, no interface change and bug isn't in a release.
## What does this PR (Pull Request) do?
Fixes `traffic_ops/v3-client.GetTopologiesWithHdr`.
- [x] This PR is not related to any other Issue
## Which Traffic Control components are affected by this PR?
- Traffic Control Client Go
## What is the best way to verify this PR?
Run TO API Tests. Run ORT Integration tests.. Run ORT against a TO with Topologies. Write an app calling `traffic_ops/v3-client.GetTopologiesWithHdr`.
## If this is a bug fix, what versions of Traffic Control are affected?
- master
-
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5521: Fix TOclient topologies path
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #5521:
URL: https://github.com/apache/trafficcontrol/pull/5521#discussion_r576938853
##########
File path: traffic_ops/testing/api/v3/topologies_test.go
##########
@@ -61,6 +62,19 @@ func CreateTestTopologies(t *testing.T) {
}
}
+func GetTestTopologies(t *testing.T) {
Review comment:
For posterity, we should also add this test to the v4 tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #5521: Fix TOclient topologies path
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5521:
URL: https://github.com/apache/trafficcontrol/pull/5521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5521: Fix TOclient topologies path
Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #5521:
URL: https://github.com/apache/trafficcontrol/pull/5521#discussion_r579548288
##########
File path: traffic_ops/testing/api/v3/topologies_test.go
##########
@@ -61,6 +62,19 @@ func CreateTestTopologies(t *testing.T) {
}
}
+func GetTestTopologies(t *testing.T) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org