You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/08 01:37:39 UTC
[GitHub] [airflow] josh-fell opened a new pull request #18076: Adding CI check to verify __init__.py file exists in providers' example_dags directories
josh-fell opened a new pull request #18076:
URL: https://github.com/apache/airflow/pull/18076
Two of the last three provider releases have had missing `__init__.py` files in the `example_dags` directory making these DAGs not part of an explicit namespace package. Based on [a previous PR discussion](https://github.com/apache/airflow/pull/18019#issuecomment-912825048), this PR adds a check to verify that if providers have example DAGs, there is must be an `__init__.py` file present in the corresponding `example_dags` directory.
The CI check will fail if an `example_dags` directory exists for any provider without an `__init__.py` file but will ultimately create any missing files with the proper ASF license text.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18076: Adding CI check to verify __init__.py file exists in providers' example_dags directories
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18076:
URL: https://github.com/apache/airflow/pull/18076#issuecomment-914912656
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18076: Adding CI check to verify __init__.py file exists in providers' example_dags directories
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18076:
URL: https://github.com/apache/airflow/pull/18076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org