You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/29 05:58:10 UTC

[GitHub] [incubator-mxnet] shimst3r opened a new pull request #20714: [DOC] Fix wrong imports in Gluon Crash Course Step 4

shimst3r opened a new pull request #20714:
URL: https://github.com/apache/incubator-mxnet/pull/20714


   `metrics` is a submodule of `mxnet`, not of `mxnet.gluon`
   
   ## Description ##
   In Step 4 of the Gluon Crash Course, metrics are imported from `mxnet.gluon.metrics`, but should be imported from `mxnet.metrics` instead. I update the documentation accordingly.
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [x] Updated documentation of Crash Course Step 4
   
   ## Comments ##
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20714: [DOC] Fix wrong imports in Gluon Crash Course Step 4

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20714:
URL: https://github.com/apache/incubator-mxnet/pull/20714#issuecomment-954451680


   Hey @shimst3r , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, windows-cpu, edge, miscellaneous, centos-gpu, centos-cpu, unix-cpu, website, windows-gpu, sanity, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] shimst3r closed pull request #20714: [DOC] Fix wrong imports in Gluon Crash Course Step 4

Posted by GitBox <gi...@apache.org>.
shimst3r closed pull request #20714:
URL: https://github.com/apache/incubator-mxnet/pull/20714


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] shimst3r commented on pull request #20714: [DOC] Fix wrong imports in Gluon Crash Course Step 4

Posted by GitBox <gi...@apache.org>.
shimst3r commented on pull request #20714:
URL: https://github.com/apache/incubator-mxnet/pull/20714#issuecomment-955183701


   @barry-jin Oh I see! That makes a lot of sense, thanks for linking the migration guide as well. :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] barry-jin commented on pull request #20714: [DOC] Fix wrong imports in Gluon Crash Course Step 4

Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20714:
URL: https://github.com/apache/incubator-mxnet/pull/20714#issuecomment-955069005


   > Curious! The CI complains about
   > 
   > ```python
   > ModuleNotFoundError: No module named 'mxnet.metric'
   > ```
   > 
   > On my local machine, I get the error
   > 
   > ```python
   > ModuleNotFoundError: No module named 'mxnet.gluon.metric'
   > ```
   > 
   > I'm on `1.8.0`, using `mxnet-1.8.0.post0-py2.py3-none-manylinux2014_x86_64.whl`
   
   Hi @shimst3r, metric package in MXNet master branch has been moved to gluon, you can follow the migration guide [here](https://mxnet.apache.org/versions/master/api/python/docs/tutorials/getting-started/gluon_migration_guide.html#Metrics). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] shimst3r commented on pull request #20714: [DOC] Fix wrong imports in Gluon Crash Course Step 4

Posted by GitBox <gi...@apache.org>.
shimst3r commented on pull request #20714:
URL: https://github.com/apache/incubator-mxnet/pull/20714#issuecomment-954573207


   Curious! The CI complains about
   
   ```python
   ModuleNotFoundError: No module named 'mxnet.metric'
   ```
   
   On my local machine, I get the error
   
   ```python
   ModuleNotFoundError: No module named 'mxnet.gluon.metric'
   ```
   
   I'm on `1.8.0`, using `mxnet-1.8.0.post0-py2.py3-none-manylinux2014_x86_64.whl`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org