You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 12:25:22 UTC

[GitHub] [arrow] jorisvandenbossche commented on pull request #10199: ARROW-12431: [C++] Mask is inverted when creating FixedSizeBinaryArray

jorisvandenbossche commented on pull request #10199:
URL: https://github.com/apache/arrow/pull/10199#issuecomment-832645495


   Not necessarily related to this PR (just noticed while looking at the code and testing a few things), but the conversion for fixed size binary is currently (on master) incorrect for the strided case:
   
   ```
   In [38]: arr = np.array([b"ab", b"cd", b"ef"])
   
   In [39]: arr[::2]
   Out[39]: array([b'ab', b'ef'], dtype='|S2')
   
   In [41]: pa.array(arr[::2], pa.binary(2)).to_pylist()
   Out[41]: [b'ab', b'cd']
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org