[GitHub] [james-project] chibenwa commented on a change in pull request #293: JAMES-3500 Improve build stability

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #293:
URL: https://github.com/apache/james-project/pull/293#discussion_r575196722



##########
File path: server/mailet/mock-smtp-server/src/main/java/org/apache/james/mock/smtp/server/testing/MockSmtpServerExtension.java
##########
@@ -43,7 +44,8 @@
 
         DockerMockSmtp() {
             mockSmtpServer = DockerContainer.fromName(Images.MOCK_SMTP_SERVER)
-                .withLogConsumer(outputFrame -> LOGGER.debug("MockSMTP: " + outputFrame.getUtf8String()));
+                .withLogConsumer(outputFrame -> LOGGER.debug("MockSMTP: " + outputFrame.getUtf8String()))
+                .waitingFor(Wait.forLogMessage(".*Mock SMTP server started.*", 1));

Review comment:
       HostPortWaitStrategy -> `Waits until a socket connection can be established on a port exposed or mapped by the container.`
   
   I understand `any` not `all`.
   
   A look at InternalCommandPortListeningCheck however tends to confirm what you say.
   
   I will switch back to HostPortWaitStrategy and propose a PR upstream for fixing the ambiguous javadoc.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org