You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 20:34:53 UTC

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4218: test: make t/plugin/log-rotate.t stable

Yiyiyimu commented on a change in pull request #4218:
URL: https://github.com/apache/apisix/pull/4218#discussion_r630522069



##########
File path: t/plugin/log-rotate.t
##########
@@ -173,11 +173,13 @@ plugins:
                 end
             end
 
-            ngx.say(n_split_error_file)
+            -- Before hot reload, the log rotate may or may not take effect.

Review comment:
       could we wait for some time before hot reload to make sure log rotate take effect




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org