You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/04/26 09:46:24 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #7436: Python: Update pre-commit to the latest version
Fokko opened a new pull request, #7436:
URL: https://github.com/apache/iceberg/pull/7436
Removed some ignores and removed some list materialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7436: Python: Update pre-commit to the latest version
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7436:
URL: https://github.com/apache/iceberg/pull/7436#issuecomment-1530339984
Thanks @JonasJ-ap and @nastra for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7436: Python: Update pre-commit to the latest version
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7436:
URL: https://github.com/apache/iceberg/pull/7436#discussion_r1177631282
##########
python/tests/utils/test_bin_packing.py:
##########
@@ -41,7 +41,7 @@ def weight_func(x: int) -> int:
return max(x, open_cost)
item_list_sums: List[int] = [sum(item) for item in PackingIterator(splits, split_size, lookback, weight_func)]
- assert all([split_size >= item_sum >= 0 for item_sum in item_list_sums])
+ assert all(split_size >= item_sum >= 0 for item_sum in item_list_sums)
Review Comment:
This is a very nice check because it will exit the loop when one `false` has been encountered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7436: Python: Update pre-commit to the latest version
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7436:
URL: https://github.com/apache/iceberg/pull/7436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org