You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/04/22 00:22:42 UTC

[GitHub] [arrow] assignUser commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS

assignUser commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1174235099


##########
cpp/build-support/run-test.sh:
##########
@@ -60,6 +60,9 @@ rm -f $LOGFILE $LOGFILE.gz
 
 pipe_cmd=cat
 
+# Install the gcs testbench
+sh ../../../../../ci/scripts/install_gcs_testbench.sh default

Review Comment:
   I think this is quite confusing without following the previous code in detail. I think doing this in relation to `$ROOT` would make it a bit clearer?
   ```suggestion
   sh $ROOT/../ci/scripts/install_gcs_testbench.sh default
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org