You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/12/30 12:37:34 UTC
[GitHub] [ignite] ibessonov opened a new pull request #7219: IGNITE-12514
Fixed WAL don't flush several last records in LOG-ONLY/FSYNC mode if flush
ptr=null
ibessonov opened a new pull request #7219: IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC mode if flush ptr=null
URL: https://github.com/apache/ignite/pull/7219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] AMashenkov commented on a change in pull request #7219:
IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC
mode if flush ptr=null
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7219: IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC mode if flush ptr=null
URL: https://github.com/apache/ignite/pull/7219#discussion_r364713533
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/IgniteWriteAheadLogManager.java
##########
@@ -90,8 +90,10 @@ public WALPointer log(WALRecord entry, RolloverType rolloverType)
* @throws IgniteCheckedException If failed to write.
* @throws StorageException If IO exception occurred during the write. If an exception is thrown from this
* method, the WAL will be invalidated and the node will be stopped.
+ * @return Last WAL position which was flushed to WAL segment file. May be greater than or equal to a {@code ptr}.
+ * May be {@code null}, it means nothing has been flushed.
*/
- public void flush(WALPointer ptr, boolean explicitFsync) throws IgniteCheckedException, StorageException;
+ public WALPointer flush(WALPointer ptr, boolean explicitFsync) throws IgniteCheckedException, StorageException;
Review comment:
Let's add @Nullable annotation to return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] AMashenkov commented on a change in pull request #7219:
IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC
mode if flush ptr=null
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7219: IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC mode if flush ptr=null
URL: https://github.com/apache/ignite/pull/7219#discussion_r364714312
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/IgniteWriteAheadLogManager.java
##########
@@ -90,8 +90,10 @@ public WALPointer log(WALRecord entry, RolloverType rolloverType)
* @throws IgniteCheckedException If failed to write.
* @throws StorageException If IO exception occurred during the write. If an exception is thrown from this
* method, the WAL will be invalidated and the node will be stopped.
+ * @return Last WAL position which was flushed to WAL segment file. May be greater than or equal to a {@code ptr}.
Review comment:
@return Last WAL position which was flushed to WAL segment file. Greater than or equal to a {@code ptr} if flush was successful, {@code null} otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] AMashenkov commented on a change in pull request #7219:
IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC
mode if flush ptr=null
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7219: IGNITE-12514 Fixed WAL don't flush several last records in LOG-ONLY/FSYNC mode if flush ptr=null
URL: https://github.com/apache/ignite/pull/7219#discussion_r364715674
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/filehandle/FileHandleManager.java
##########
@@ -66,6 +66,8 @@
* @param explicitFsync {@code true} if fsync required.
* @throws IgniteCheckedException if fail.
* @throws StorageException if storage was fail.
+ * @return Last WAL position which was flushed to WAL segment file. May be greater than or equal to a {@code ptr}.
Review comment:
Let's avoid "May be" here and describe certain cases properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services