You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/08/20 00:46:24 UTC
Review Request 13675: Added a slave load hint for scheduler sorting.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Added a slave load hint for scheduler sorting.
With this change, the offers will include a slave load hint based on the
5 minute load average for that slave (returned from getloadavg()).
Frameworks can use this hint to select among otherwise similar offers,
as an optimization.
Diffs
-----
include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d
src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
src/slave/slave.cpp 92a0a7edb46eb3525e193c81129291e405cebaad
Diff: https://reviews.apache.org/r/13675/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 13675: Added a slave load hint for scheduler sorting.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/#review36718
-----------------------------------------------------------
Bad patch!
Reviews applied: [13675]
Failed command: git apply --index 13675.patch
Error:
error: patch failed: src/master/master.hpp:114
error: src/master/master.hpp: patch does not apply
error: patch failed: src/master/master.cpp:1349
error: src/master/master.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 26, 2013, 10:38 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13675/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added a slave load hint for scheduler sorting.
>
> With this change, the offers will include a slave load hint based on the
> 5 minute load average for that slave (returned from getloadavg()).
> Frameworks can use this hint to select among otherwise similar offers,
> as an optimization.
>
> Review: https://reviews.apache.org/r/13675
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
> src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
> src/master/master.cpp dc155ba7225ed194525f6ae2a6b96ca8dbdfa432
> src/slave/slave.cpp 3e2c6007ca2fbf210a76af376bb5bac5fa32594f
>
> Diff: https://reviews.apache.org/r/13675/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13675: Added a slave load hint for scheduler
sorting.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On March 10, 2014, 3:07 p.m., Niklas Nielsen wrote:
> > https://reviews.apache.org/r/17325 expose system load for both masters and slaves. So you should be able to get statistics with the offer.hostname at hand.
> > Do you still want to hang statistics off the offer?
Closing for now.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/#review36713
-----------------------------------------------------------
On Aug. 26, 2013, 3:38 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13675/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 3:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a slave load hint for scheduler sorting.
>
> With this change, the offers will include a slave load hint based on the
> 5 minute load average for that slave (returned from getloadavg()).
> Frameworks can use this hint to select among otherwise similar offers,
> as an optimization.
>
> Review: https://reviews.apache.org/r/13675
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
> src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
> src/master/master.cpp dc155ba7225ed194525f6ae2a6b96ca8dbdfa432
> src/slave/slave.cpp 3e2c6007ca2fbf210a76af376bb5bac5fa32594f
>
> Diff: https://reviews.apache.org/r/13675/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13675: Added a slave load hint for scheduler sorting.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/#review36713
-----------------------------------------------------------
https://reviews.apache.org/r/17325 expose system load for both masters and slaves. So you should be able to get statistics with the offer.hostname at hand.
Do you still want to hang statistics off the offer?
- Niklas Nielsen
On Aug. 26, 2013, 3:38 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13675/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 3:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added a slave load hint for scheduler sorting.
>
> With this change, the offers will include a slave load hint based on the
> 5 minute load average for that slave (returned from getloadavg()).
> Frameworks can use this hint to select among otherwise similar offers,
> as an optimization.
>
> Review: https://reviews.apache.org/r/13675
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
> src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
> src/master/master.cpp dc155ba7225ed194525f6ae2a6b96ca8dbdfa432
> src/slave/slave.cpp 3e2c6007ca2fbf210a76af376bb5bac5fa32594f
>
> Diff: https://reviews.apache.org/r/13675/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13675: Added a slave load hint for scheduler sorting.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 10:38 p.m.)
Review request for mesos.
Changes
-------
I was returning the 1-minute load average, rather than the 5-minute load average.
Repository: mesos-git
Description
-------
Added a slave load hint for scheduler sorting.
With this change, the offers will include a slave load hint based on the
5 minute load average for that slave (returned from getloadavg()).
Frameworks can use this hint to select among otherwise similar offers,
as an optimization.
Review: https://reviews.apache.org/r/13675
Diffs (updated)
-----
include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
src/master/master.cpp dc155ba7225ed194525f6ae2a6b96ca8dbdfa432
src/slave/slave.cpp 3e2c6007ca2fbf210a76af376bb5bac5fa32594f
Diff: https://reviews.apache.org/r/13675/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 13675: Added a slave load hint for scheduler sorting.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 5:39 p.m.)
Review request for mesos.
Changes
-------
The previous patch was erroneous.
Repository: mesos-git
Description
-------
Added a slave load hint for scheduler sorting.
With this change, the offers will include a slave load hint based on the
5 minute load average for that slave (returned from getloadavg()).
Frameworks can use this hint to select among otherwise similar offers,
as an optimization.
Review: https://reviews.apache.org/r/13675
Diffs (updated)
-----
include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
src/master/master.cpp dc155ba7225ed194525f6ae2a6b96ca8dbdfa432
src/slave/slave.cpp 3e2c6007ca2fbf210a76af376bb5bac5fa32594f
Diff: https://reviews.apache.org/r/13675/diff/
Testing
-------
make check
Thanks,
Brenden Matthews
Re: Review Request 13675: Added a slave load hint for scheduler sorting.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13675/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 10:48 p.m.)
Review request for mesos.
Changes
-------
Fixed comment & log message.
Repository: mesos-git
Description (updated)
-------
Added a slave load hint for scheduler sorting.
With this change, the offers will include a slave load hint based on the
5 minute load average for that slave (returned from getloadavg()).
Frameworks can use this hint to select among otherwise similar offers,
as an optimization.
Review: https://reviews.apache.org/r/13675
Diffs (updated)
-----
include/mesos/mesos.proto bbf1d31a8a51c58d7118a0d61f24e47f7b6f1b11
src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d
src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
src/slave/slave.cpp 92a0a7edb46eb3525e193c81129291e405cebaad
Diff: https://reviews.apache.org/r/13675/diff/
Testing
-------
make check
Thanks,
Brenden Matthews