You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/12/10 08:10:38 UTC

Review Request 41196: SQOOP-2717: Sqoop2: Use connector name in shell

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41196/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

The connector id is removed from public interface, the shell should use connector name instead of connector id.


Diffs
-----

  shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java e5af3f1 
  shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 07cccf2 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 600de8b 
  shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 663a377 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java c385434 
  shell/src/main/resources/shell-resource.properties 50c32b6 
  shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 11c670b 
  shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 37c7cf6 

Diff: https://reviews.apache.org/r/41196/diff/


Testing
-------


Thanks,

Colin Ma

Re: Review Request 41196: SQOOP-2717: Sqoop2: Use connector name in shell

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41196/#review109741
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Dec. 10, 2015, 7:10 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41196/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 7:10 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The connector id is removed from public interface, the shell should use connector name instead of connector id.
> 
> 
> Diffs
> -----
> 
>   shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java e5af3f1 
>   shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 07cccf2 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 600de8b 
>   shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 663a377 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java c385434 
>   shell/src/main/resources/shell-resource.properties 50c32b6 
>   shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 11c670b 
>   shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 37c7cf6 
> 
> Diff: https://reviews.apache.org/r/41196/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>