You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/07/06 18:04:41 UTC
[GitHub] [solr] gerlowskija opened a new pull request #204: SOLR-15490: /cluster v2 API parameter mapping tests
gerlowskija opened a new pull request #204:
URL: https://github.com/apache/solr/pull/204
# Description
We had only partial test coverage for the v2<->v1 parameter mapping of APIs under the /cluster endpoint.
# Solution
This PR adds tests for most APIs under the /cluster path.
# Tests
See above.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #204: SOLR-15490: /cluster v2 API parameter mapping tests
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #204:
URL: https://github.com/apache/solr/pull/204#issuecomment-875631926
LGTM. This code feels very "complex" for what I think should be simple testing of API inputs and outputs ;-). However lots of places in Solr I have that feeling ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #204: SOLR-15490: /cluster v2 API parameter mapping tests
Posted by GitBox <gi...@apache.org>.
gerlowskija merged pull request #204:
URL: https://github.com/apache/solr/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #204: SOLR-15490: /cluster v2 API parameter mapping tests
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on pull request #204:
URL: https://github.com/apache/solr/pull/204#issuecomment-876461154
Fair enough, re: "complexity". If you see anything concrete that you'd improve, lmk. I'm not married to any particular way of doing this, I just want _something_ to make sure that we're getting the conversion right as I migrate things from using the apispec JSON files over to AnnotatedApi.
I still need to run all tests, but will aim to merge in the next day or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org