[jira] [Commented] (AIRFLOW-5840) Add a link to the external task that ExternalTaskSensor is waiting for

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012171#comment-17012171 ] 

ASF GitHub Bot commented on AIRFLOW-5840:
-----------------------------------------

rconroy293 commented on pull request #7119: [AIRFLOW-5840] Add operator extra link to external task sensor
URL: https://github.com/apache/airflow/pull/7119
 
 
   This adds an "operator extra link" by default to external task sensors, linking to the graph of the DAG run they're waiting for. If multiple execution dates are being waited for, the link instead is not provided.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a link to the external task that ExternalTaskSensor is waiting for
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-5840
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5840
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.10.6
>            Reporter: Qian Yu
>            Assignee: Robert Conroy
>            Priority: Major
>              Labels: ExternalTaskSensor, Target, get_link, link
>
> When using ExternalTaskSensor, there's no indication on the Web UI regarding which task the sensor is waiting for. Does anyone have ideas for improving this? 
> One idea is to override the get_link() abstract method of ExternalTaskSensor and point it to the task that the sensor waits for. Maybe something like this (just for demo, not tested and likely not working):
> {code:python}
> def get_link(self, operator: BaseOperator, dttm: datetime) -> str:
>      return "{}?dag_id={}&task_id={}&execution_date={}".format(conf["base_url"], self.external_task_id, self.execution_date.isoformat())
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)