You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 14:30:46 UTC
[GitHub] [spark] tgravescs commented on issue #26633: [SPARK-29994][CORE]
Add WILDCARD task location
tgravescs commented on issue #26633: [SPARK-29994][CORE] Add WILDCARD task location
URL: https://github.com/apache/spark/pull/26633#issuecomment-560420362
In my opinion the ideal thing is to fix SPARK-18886, its the perfect time, this is a new major release and this isn't something impacting production now so we don't really need a "quick fix". I disagree with your comment there is no perfect solution, no one here has tried and really no one here has give me any metrics as to why this is so important of a fix.
But I realize that is a lot more change so I'm ok with this going in as a temporary fix. Please update based on the comments made - I want to make sure this is clearly documented in the code has a hack that will go away and no on else should use it.
Also can someone give me any performance metrics - how much of a different does the LocalShuffledRowRDD make?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org