[GitHub] [beam] tvalentyn commented on a diff in pull request #28290: Avoid when change point is last index of metric values

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on code in PR #28290:
URL: https://github.com/apache/beam/pull/28290#discussion_r1316088205


##########
sdks/python/apache_beam/testing/analyzers/perf_analysis_utils.py:
##########
@@ -170,6 +170,10 @@ def find_latest_change_point_index(metric_values: List[Union[float, int]]):
   if not change_points_indices:
     return None
   change_points_indices.sort()
+  # If the latest change point is the last index of the metric_values,
+  # then consider it as no change point since it might be a flake.
+  if len(metric_values) - 1 == change_points_indices[-1]:

Review Comment:
   What if the inputs look like `1, 1 1, 1, 1, 200, 1` -  will we still have an alert?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org