You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/09 20:14:26 UTC

[GitHub] [spark] srowen commented on issue #26799: [SPARK-30170][SQL][MLLIB] Eliminate compilation warnings: part 1

srowen commented on issue #26799: [SPARK-30170][SQL][MLLIB] Eliminate compilation warnings: part 1
URL: https://github.com/apache/spark/pull/26799#issuecomment-563416381
 
 
   Up to you about what is most efficient. If it's a bunch of misc tiny issues, you can put them together. The only thing I try to do is not split solutions to the same class of problem over two PRs if it's easy not to. For example for Scala 2.13 there are like 10+ distinct types of change. For anything important or touching many files I do one PR. But for the last few that involve a file or two each will probably batch them together. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org