[GitHub] [ozone] mukul1987 commented on a diff in pull request #3487: HDDS-6838. [FSO] Sets OM default to LEGACY for an older client's bucket create request

[GitBox <gi...@apache.org>]

mukul1987 commented on code in PR #3487:
URL: https://github.com/apache/ozone/pull/3487#discussion_r891347526


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -270,6 +270,36 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
     }
   }
 
+  private BucketLayout getDefaultBucketLayout(OzoneManager ozoneManager,
+      BucketInfo bucketInfo, String volumeName, String bucketName) {
+
+    if (getOmRequest().getVersion() <
+        ClientVersion.BUCKET_LAYOUT_SUPPORT.toProtoValue()) {
+
+      if (LOG.isDebugEnabled()) {

Review Comment:
   This should mostly be a LOG.info message. or we should add a metric around it to identify cases where buckets are created from older client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org